gh-Mbed-TLS/TF-PSA-Crypto
Watch
1
0
Fork
You've already forked TF-PSA-Crypto
 0
Code Issues 167 Pull requests 92 Releases 5 Activity

Fix false positives in constant time tests using MSan with Clang 16 #170

Open
gilles-peskine-arm wants to merge 4 commits from gilles-peskine-arm/msancf-clang16-crypto into development
pull from: gilles-peskine-arm/msancf-clang16-crypto
merge into: gh-Mbed-TLS:development
Conversation 4 Commits 4 Files changed 5 +139 -8
gilles-peskine-arm commented 2025-01-29 11:11:10 -06:00 (Migrated from github.com)

Fix false positives of constant-flow testing when using MBEDTLS_TEST_CONSTANT_FLOW_MEMSAN on Clang 16 and above. Fixes https://github.com/Mbed-TLS/mbedtls/issues/9921.

This isn't needed for the CI (in the short to medium term) because still we do this testing on an old platform with an old Clang, but is needed on typical developer machines nowadays.

PR checklist

Fix false positives of constant-flow testing when using `MBEDTLS_TEST_CONSTANT_FLOW_MEMSAN` on Clang 16 and above. Fixes https://github.com/Mbed-TLS/mbedtls/issues/9921. This isn't needed for the CI (in the short to medium term) because still we do this testing on an old platform with an old Clang, but is needed on typical developer machines nowadays. ## PR checklist - [x] **changelog** not required because: test only - [x] **development PR** https://github.com/Mbed-TLS/mbedtls/pull/9942 - [x] **crypto PR** here - [x] **framework PR** not required - [x] **3.6 PR** https://github.com/Mbed-TLS/mbedtls/pull/9922 - [x] **2.28 PR** https://github.com/Mbed-TLS/mbedtls/pull/9943 - **tests** provided for non-regression; requires local testing with Clang ≥16 to validate that #9921 is fixed.
mpg (Migrated from github.com) reviewed 2025-01-29 11:11:10 -06:00
waleed-elmelegy-arm (Migrated from github.com) reviewed 2025-01-30 11:21:05 -06:00
waleed-elmelegy-arm (Migrated from github.com) left a comment
No description provided.
LGTM
gilles-peskine-arm commented 2025-02-10 15:41:41 -06:00 (Migrated from github.com)

Now that https://github.com/Mbed-TLS/TF-PSA-Crypto/pull/135 is merged, this is incomplete: there is now a test component to update in crypto as well as mbedtls. So I've rebased on top of development and added a commit to update the component (similar to the one in mbedtls).

Now that https://github.com/Mbed-TLS/TF-PSA-Crypto/pull/135 is merged, this is incomplete: there is now a test component to update in crypto as well as mbedtls. So I've rebased on top of `development` and added a commit to update the component (similar to the one in mbedtls).
gilles-peskine-arm commented 2025-04-24 12:58:43 -05:00 (Migrated from github.com)

I'm rebasing again because the CI was failing on test_psa_compliance, I'm guessing because https://github.com/Mbed-TLS/TF-PSA-Crypto/pull/173 was an incompatible change.

I'm rebasing again because the CI was failing on `test_psa_compliance`, I'm guessing because https://github.com/Mbed-TLS/TF-PSA-Crypto/pull/173 was an incompatible change.
This pull request is broken due to missing fork information.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin 'gilles-peskine-arm/msancf-clang16-crypto:gilles-peskine-arm/msancf-clang16-crypto'
git switch 'gilles-peskine-arm/msancf-clang16-crypto'

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch 'development'
git merge --no-ff 'gilles-peskine-arm/msancf-clang16-crypto'
git switch 'gilles-peskine-arm/msancf-clang16-crypto'
git rebase 'development'
git switch 'development'
git merge --ff-only 'gilles-peskine-arm/msancf-clang16-crypto'
git switch 'gilles-peskine-arm/msancf-clang16-crypto'
git rebase 'development'
git switch 'development'
git merge --no-ff 'gilles-peskine-arm/msancf-clang16-crypto'
git switch 'development'
git merge --squash 'gilles-peskine-arm/msancf-clang16-crypto'
git switch 'development'
git merge --ff-only 'gilles-peskine-arm/msancf-clang16-crypto'
git switch 'development'
git merge 'gilles-peskine-arm/msancf-clang16-crypto'
git push origin 'development'
Sign in to join this conversation.
Reviewers
No reviewers
mpg
Labels
Clear labels   
api-break
This issue/PR breaks the API and must wait for a new major version

  
approved
Design and code approved - may be waiting for CI or backports

  
bug
Something isn't working

  
component-docs
Docs / website issues filed here for tracking

  
component-platform
Portability layer and build scripts

  
component-test
Test framework and CI scripts

  
dependencies
Pull requests that update a dependency file

  
deprecation
needs deprecation announcement

  
DO-NOT-MERGE

   
enhancement
New feature or request

  
good first issue
Good for newcomers

  
help wanted
This issue is not being actively worked on, but PRs welcome.

  
needs-adoption
stalled PR that someone should pick up and complete

  
needs-backports
Backports are missing or are pending review and approval.

  
needs-ci
Needs to pass CI tests

  
needs-design-approval
Needs design discussion / approval

  
needs-info
An issue or PR which needs further info from the reporter / author

  
needs-preceding-pr
Requires another PR to be merged first

  
needs-review
Every commit must be reviewed by at least two team members

  
needs-reviewer
This PR needs someone to pick it up for review

  
needs-work

   
priority-high
High priority - will be reviewed soon

  
priority-low
Low priority - this may not receive review soon

  
priority-medium
Medium priority - this can be reviewed as time permits

  
priority-scheduled
This PR is big - it will require time to be scheduled for review

  
priority-very-high
Highest priority - prioritise this over other review work

  
resolved-after-1.1
The issue is resolved in development, but still present in 1.1 LTS.

  
single-reviewer
This PR qualifies for having only one reviewer

  
size-l
Estimated task size: large (2w+)

  
size-m
Estimated task size: medium (~1w)

  
size-optimisation

   
size-s
Estimated task size: small (~2d)

  
size-xs
Estimated task size: extra small (a few hours at most)

No labels
api-break
approved
bug
component-docs
component-platform
component-test
dependencies
deprecation
DO-NOT-MERGE
enhancement
good first issue
help wanted
needs-adoption
needs-backports
needs-ci
needs-design-approval
needs-info
needs-preceding-pr
needs-review
needs-reviewer
needs-work
priority-high
priority-low
priority-medium
priority-scheduled
priority-very-high
resolved-after-1.1
single-reviewer
size-l
size-m
size-optimisation
size-s
size-xs
Milestone
Clear milestone
No items
No milestone
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
gh-Mbed-TLS/TF-PSA-Crypto!170
No description provided.