Remove RNG parameters from LMS #182

Merged

bjwtaylor merged 3 commits from remove-rng-parameters-from-lms into development

2025-03-13 11:27:01 -05:00

bjwtaylor commented

2025-02-25 02:34:46 -06:00

(Migrated from github.com)

Description

Remove RNG parameters from LMS resolves https://github.com/Mbed-TLS/TF-PSA-Crypto/issues/168

PR checklist

changelog not required as we have agreed to add it it as another task once all rng removal has been completed.
framework PR not required
mbedtls PR not required because: API not used in mbedtls
mbedtls 3.6 PR not required because: API change
mbedtls 2.28 PR not required because: API change
tests not required because: no changes to test

## Description Remove RNG parameters from LMS resolves https://github.com/Mbed-TLS/TF-PSA-Crypto/issues/168 ## PR checklist - [x] **changelog** not required as we have agreed to add it it as another task once all rng removal has been completed. - [x] **framework PR** not required - [x] **mbedtls PR** not required because: API not used in mbedtls - [x] **mbedtls 3.6 PR** not required because: API change - [x] **mbedtls 2.28 PR** not required because: API change - **tests** not required because: no changes to test

gilles-peskine-arm (Migrated from github.com) requested changes

2025-02-27 11:58:09 -06:00

gilles-peskine-arm (Migrated from github.com) left a comment

LGTM except for the changelog entry

ChangeLog.d/168.txt

The changelog is about the API, not about the internals, so only lms.h is relevant (LMOTS isn't public).

The changelog is about the API, not about the internals, so only `lms.h` is relevant (LMOTS isn't public).

I think it would make sense to have a single entry for all the RNG parameter removals, rather than separate entries for each module. We might as well write it now, something like

All API functions now use the PSA random generator (psa_get_random()) internally. As a consequence, functions no longer take RNG parameters.

Also, we should give the file a more meaningful name. (The file name doesn't matter in the end, but in the meantime it's easier to find a pending changelog entry in remove-rng-parameters-from-lms.txt or remove-rng-parameters.txt than in 168.txt.)

I think it would make sense to have a single entry for all the RNG parameter removals, rather than separate entries for each module. We might as well write it now, something like > All API functions now use the PSA random generator (psa_get_random()) internally. As a consequence, functions no longer take RNG parameters. Also, we should give the file a more meaningful name. (The file name doesn't matter in the end, but in the meantime it's easier to find a pending changelog entry in `remove-rng-parameters-from-lms.txt` or `remove-rng-parameters.txt` than in `168.txt`.)

gilles-peskine-arm (Migrated from github.com) reviewed

2025-03-03 09:04:05 -06:00

ChangeLog.d/168.txt

Never mind this, as discussed this morning, let's not worry much about changelog entry organization at this stage. I've filed a separate issue to consolidate the documentation at the end. (I also added a task for the knowledge base, better do it now than forget later.)

Never mind this, as discussed this morning, let's not worry much about changelog entry organization at this stage. I've filed a [separate issue to consolidate the documentation at the end](https://github.com/Mbed-TLS/mbedtls/issues/10028). (I also added a task for the [knowledge base](https://github.com/Mbed-TLS/mbedtls-docs/issues/169), better do it now than forget later.)