[tf-psa-crypto] Make mbedtls_psa_register_se_key usable with opaque drivers #191

2025-03-07T09:10:14-06:00

valeriosetti commented

2025-03-07 09:10:14 -06:00

(Migrated from github.com)

Description

This helps resolving https://github.com/Mbed-TLS/mbedtls/issues/9255.

PR checklist

changelog todo
framework PR https://github.com/Mbed-TLS/mbedtls-framework/pull/145
mbedtls development PR https://github.com/Mbed-TLS/mbedtls/pull/10041
mbedtls 3.6 PR no
mbedtls 2.28 PR no
tests provided

## Description This helps resolving https://github.com/Mbed-TLS/mbedtls/issues/9255. ## PR checklist - [ ] **changelog** todo - [ ] **framework PR** https://github.com/Mbed-TLS/mbedtls-framework/pull/145 - [ ] **mbedtls development PR** https://github.com/Mbed-TLS/mbedtls/pull/10041 - [ ] **mbedtls 3.6 PR** no - [ ] **mbedtls 2.28 PR** no - **tests** provided

gilles-peskine-arm (Migrated from github.com) reviewed

2025-03-07 09:10:14 -06:00

bjwtaylor (Migrated from github.com) reviewed

2025-04-14 09:49:43 -05:00

core/psa_crypto.c

					
				@ -2352,0 +2359,4 @@

				    if ((attributes == NULL) || (label == NULL) || (label_length == 0) ||

				        (key_id == NULL)) {

				        return PSA_ERROR_INVALID_ARGUMENT;

We test for no label, however should we be testing for a label with zero length?

core/psa_crypto.c

					
				@ -2352,0 +2362,4 @@

				        return PSA_ERROR_INVALID_ARGUMENT;

				    }

				    if (!psa_key_lifetime_is_external(psa_get_key_lifetime(attributes))) {

Is it possible/worthwhile to craft a test to hit this case?

This pull request has changes conflicting with the target branch.

core/psa_crypto.c
include/psa/crypto_extra.h
tests/suites/test_suite_psa_crypto_driver_wrappers.data

View command line instructions

Manual merge helper

Use this merge commit message when completing the merge manually.

Merge commit title

Merge pull request '[tf-psa-crypto] Make mbedtls_psa_register_se_key usable with opaque drivers' (#191) from valeriosetti/issue9255-tfpsacrypto into development

Merge commit body

Reviewed-on: https://git.richey.dev/gh-Mbed-TLS/TF-PSA-Crypto/pulls/191

Merge pull request '[tf-psa-crypto] Make mbedtls_psa_register_se_key usable with opaque drivers' (#191) from valeriosetti/issue9255-tfpsacrypto into development

Reviewed-on: https://git.richey.dev/gh-Mbed-TLS/TF-PSA-Crypto/pulls/191

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin 'valeriosetti/issue9255-tfpsacrypto:valeriosetti/issue9255-tfpsacrypto'

git switch 'valeriosetti/issue9255-tfpsacrypto'

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch 'development'

git merge --no-ff 'valeriosetti/issue9255-tfpsacrypto'

git switch 'valeriosetti/issue9255-tfpsacrypto'

git rebase 'development'

git switch 'development'

git merge --ff-only 'valeriosetti/issue9255-tfpsacrypto'

git switch 'valeriosetti/issue9255-tfpsacrypto'

git rebase 'development'

git switch 'development'

git merge --no-ff 'valeriosetti/issue9255-tfpsacrypto'

git switch 'development'

git merge --squash 'valeriosetti/issue9255-tfpsacrypto'

git switch 'development'

git merge --ff-only 'valeriosetti/issue9255-tfpsacrypto'

git switch 'development'

git merge 'valeriosetti/issue9255-tfpsacrypto'

git push origin 'development'

Sign in to join this conversation.

No reviewers

gilles-peskine-arm

No milestone

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

gh-Mbed-TLS/TF-PSA-Crypto!191

Rows
Columns