Remove RNG from x509 and PK #194

2025-03-10T02:55:31-05:00

bjwtaylor commented

2025-03-10 02:55:31 -05:00

(Migrated from github.com)

Description

remove the f_rng and p_rng parameter from x509 and PK.

resolves https://github.com/Mbed-TLS/TF-PSA-Crypto/issues/169

Cross-depends on the associated mbedtls PR for a clean CI.

PR checklist

changelog not required because: it will be provided under a later issue
framework PR not required
mbedtls development PR provided https://github.com/Mbed-TLS/mbedtls/pull/10037
mbedtls 3.6 PR not required because: No backports (API break)
mbedtls 2.28 PR not required because: No backports (API break)
tests covered by existing tests

## Description remove the f_rng and p_rng parameter from x509 and PK. resolves https://github.com/Mbed-TLS/TF-PSA-Crypto/issues/169 Cross-depends on the associated mbedtls PR for a clean CI. ## PR checklist - [x] **changelog** not required because: it will be provided under a later issue - [x] **framework PR** not required - [x] **mbedtls development PR** provided https://github.com/Mbed-TLS/mbedtls/pull/10037 - [x] **mbedtls 3.6 PR** not required because: No backports (API break) - [x] **mbedtls 2.28 PR** not required because: No backports (API break) - **tests** covered by existing tests

mpg (Migrated from github.com) requested changes

2025-03-20 03:59:48 -05:00

mpg (Migrated from github.com) left a comment

Looks pretty good to me, just two occurrences of a minor point.

Since this PR is a single commit (which makes sense), feel free to just amend it to remove the superfluous changes - and fix the commit message while at it.

Looks pretty good to me, just two occurrences of a minor point. Since this PR is a single commit (which makes sense), feel free to just amend it to remove the superfluous changes - and fix the commit message while at it.

drivers/builtin/include/mbedtls/pk.h

					
				@ -285,4 +285,2 @@

				typedef int (*mbedtls_pk_rsa_alt_sign_func)(void *ctx,

				                                            int (*f_rng)(void *, unsigned char *, size_t),

				                                            void *p_rng,

				                                            mbedtls_md_type_t md_alg, unsigned int hashlen,

[about the commit message] Minor: this is only about PK, we don't have any x509 in this repo.

drivers/builtin/src/pk.c

Looks like a leftover from debugging, can you revert to return ctx->...?

Looks like a leftover from debugging, can you revert to `return ctx->...`?

drivers/builtin/src/pk_wrap.c

					
				@ -1303,20 +1260,16 @@ static int rsa_alt_sign_wrap(mbedtls_pk_context *pk, mbedtls_md_type_t md_alg,

				        return MBEDTLS_ERR_PK_BUFFER_TOO_SMALL;