gh-Mbed-TLS/TF-PSA-Crypto
Watch
1
0
Fork
You've already forked TF-PSA-Crypto
 0
Code Issues 167 Pull requests 92 Releases 5 Activity

asn1parse: document behavior on unexpected tags #217

Open
DemiMarie wants to merge 1 commit from DemiMarie/document-unexpected-tags into development
pull from: DemiMarie/document-unexpected-tags
merge into: gh-Mbed-TLS:development
Conversation 0 Commits 1 Files changed 1 +3 -1
DemiMarie commented 2025-03-21 00:23:43 -05:00 (Migrated from github.com)

Description

mbedtls_asn1_get_tag() does not change *p if it returns MBEDTLS_ERR_ASN1_UNEXPECTED_TAG, and code both inside and outside of Mbed TLS relies on this. Document this behavior.

PR checklist

  • changelog not required because: documentation-only
  • framework PR not required
  • mbedtls development PR not required because: documentation-only
  • mbedtls 3.6 PR not required because: documentation-only
  • mbedtls 2.28 PR not required because: documentation-only
  • tests not required because: documentation-only
## Description mbedtls_asn1_get_tag() does not change *p if it returns MBEDTLS_ERR_ASN1_UNEXPECTED_TAG, and code both inside and outside of Mbed TLS relies on this. Document this behavior. ## PR checklist - [x] **changelog** not required because: documentation-only - [x] **framework PR** not required - [x] **mbedtls development PR** not required because: documentation-only - [x] **mbedtls 3.6 PR** not required because: documentation-only - [x] **mbedtls 2.28 PR** not required because: documentation-only - [x] **tests** not required because: documentation-only
This pull request has changes conflicting with the target branch.
  • include/mbedtls/asn1.h
View command line instructions

Manual merge helper

Use this merge commit message when completing the merge manually.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin 'DemiMarie/document-unexpected-tags:DemiMarie/document-unexpected-tags'
git switch 'DemiMarie/document-unexpected-tags'

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch 'development'
git merge --no-ff 'DemiMarie/document-unexpected-tags'
git switch 'DemiMarie/document-unexpected-tags'
git rebase 'development'
git switch 'development'
git merge --ff-only 'DemiMarie/document-unexpected-tags'
git switch 'DemiMarie/document-unexpected-tags'
git rebase 'development'
git switch 'development'
git merge --no-ff 'DemiMarie/document-unexpected-tags'
git switch 'development'
git merge --squash 'DemiMarie/document-unexpected-tags'
git switch 'development'
git merge --ff-only 'DemiMarie/document-unexpected-tags'
git switch 'development'
git merge 'DemiMarie/document-unexpected-tags'
git push origin 'development'
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
api-break
This issue/PR breaks the API and must wait for a new major version

  
approved
Design and code approved - may be waiting for CI or backports

  
bug
Something isn't working

  
component-docs
Docs / website issues filed here for tracking

  
component-platform
Portability layer and build scripts

  
component-test
Test framework and CI scripts

  
dependencies
Pull requests that update a dependency file

  
deprecation
needs deprecation announcement

  
DO-NOT-MERGE

   
enhancement
New feature or request

  
good first issue
Good for newcomers

  
help wanted
This issue is not being actively worked on, but PRs welcome.

  
needs-adoption
stalled PR that someone should pick up and complete

  
needs-backports
Backports are missing or are pending review and approval.

  
needs-ci
Needs to pass CI tests

  
needs-design-approval
Needs design discussion / approval

  
needs-info
An issue or PR which needs further info from the reporter / author

  
needs-preceding-pr
Requires another PR to be merged first

  
needs-review
Every commit must be reviewed by at least two team members

  
needs-reviewer
This PR needs someone to pick it up for review

  
needs-work

   
priority-high
High priority - will be reviewed soon

  
priority-low
Low priority - this may not receive review soon

  
priority-medium
Medium priority - this can be reviewed as time permits

  
priority-scheduled
This PR is big - it will require time to be scheduled for review

  
priority-very-high
Highest priority - prioritise this over other review work

  
resolved-after-1.1
The issue is resolved in development, but still present in 1.1 LTS.

  
single-reviewer
This PR qualifies for having only one reviewer

  
size-l
Estimated task size: large (2w+)

  
size-m
Estimated task size: medium (~1w)

  
size-optimisation

   
size-s
Estimated task size: small (~2d)

  
size-xs
Estimated task size: extra small (a few hours at most)

No labels
api-break
approved
bug
component-docs
component-platform
component-test
dependencies
deprecation
DO-NOT-MERGE
enhancement
good first issue
help wanted
needs-adoption
needs-backports
needs-ci
needs-design-approval
needs-info
needs-preceding-pr
needs-review
needs-reviewer
needs-work
priority-high
priority-low
priority-medium
priority-scheduled
priority-very-high
resolved-after-1.1
single-reviewer
size-l
size-m
size-optimisation
size-s
size-xs
Milestone
Clear milestone
No items
No milestone
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
gh-Mbed-TLS/TF-PSA-Crypto!217
No description provided.