add handling for default CMAKE_BUILD_TYPE values #222

Closed

jurassicLizard wants to merge 4 commits from development into development

jurassicLizard commented

2025-03-21 10:37:36 -05:00

(Migrated from github.com)

Description

validate that CMAKE_BUILD_TYPE is an accepted value if we are a root project
warn that CMAKE_BUILD_TYPE is invalid if parent project uses an unrecognized build type
Fail if we are a root project and the build type is unrecognized

PR checklist

Please remove the segment/s on either side of the | symbol as appropriate, and add any relevant link/s to the end of the line.
If the provided content is part of the present PR remove the # symbol.

changelog provided
framework PR provided Mbed-TLS/mbedtls-framework | not required
mbedtls development PR provided Mbed-TLS/mbedtls | https://github.com/Mbed-TLS/mbedtls/pull/10079
mbedtls 3.6 PR provided Mbed-TLS/mbedtls# | https://github.com/Mbed-TLS/mbedtls/pull/10084
mbedtls 2.28 PR provided Mbed-TLS/mbedtls# | not required because: too outdated for changes
tests provided | ~~not required because:~~

https://github.com/jurassicLizard/mbed-tls-cmake-build-test/tree/TF-PSA-Crypto/development

Notes for the submitter

Please refer to the contributing guidelines, especially the
checklist for PR contributors.

Help make review efficient:

Multiple simple commits
- please structure your PR into a series of small commits, each of which does one thing
Avoid force-push
- please do not force-push to update your PR - just add new commit(s)
See our Guidelines for Contributors for more details about the review process.

## Description - validate that CMAKE_BUILD_TYPE is an accepted value if we are a root project - warn that CMAKE_BUILD_TYPE is invalid if parent project uses an unrecognized build type - Fail if we are a root project and the build type is unrecognized related to : https://github.com/Mbed-TLS/mbedtls/pull/10079 ## PR checklist Please remove the segment/s on either side of the | symbol as appropriate, and add any relevant link/s to the end of the line. If the provided content is part of the present PR remove the # symbol. - [x] **changelog** provided - [x] **framework PR** provided Mbed-TLS/mbedtls-framework | not required - [x] **mbedtls development PR** provided Mbed-TLS/mbedtls | https://github.com/Mbed-TLS/mbedtls/pull/10079 - [x] **mbedtls 3.6 PR** provided Mbed-TLS/mbedtls# | https://github.com/Mbed-TLS/mbedtls/pull/10084 - [x] **mbedtls 2.28 PR** provided Mbed-TLS/mbedtls# | not required because: too outdated for changes - [x] **tests** provided | ~~not required because:~~ https://github.com/jurassicLizard/mbed-tls-cmake-build-test/tree/TF-PSA-Crypto/development ## Notes for the submitter Please refer to the [contributing guidelines](https://github.com/Mbed-TLS/TF-PSA-Crypto/blob/development/CONTRIBUTING.md), especially the checklist for PR contributors. Help make review efficient: * Multiple simple commits - please structure your PR into a series of small commits, each of which does one thing * Avoid force-push - please do not force-push to update your PR - just add new commit(s) * See our [Guidelines for Contributors](https://mbed-tls.readthedocs.io/en/latest/reviews/review-for-contributors/) for more details about the review process.

jurassicLizard commented

2025-11-19 07:56:39 -06:00

(Migrated from github.com)

closed due to inaction. tying loose ends requiring extra overhead to recheck changes

Pull request closed

Please reopen this pull request to perform a merge.

No reviewers

No milestone

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

gh-Mbed-TLS/TF-PSA-Crypto!222

No description provided.

Rows
Columns