Squash the driver libraries into the tfpsacrypto library #332

Merged

ronald-cron-arm merged 10 commits from one-crypto-library into development

2025-07-03 03:56:51 -05:00

ronald-cron-arm commented

2025-06-25 07:15:58 -05:00

(Migrated from github.com)

Description

The PSA core calls the driver code, and the reverse is also true. Due to these cross-references, they cannot be built into separate libraries, so squash everything into a single one.

While this PR moves all the crypto code to the tfpsacrypto library, the last commit adds dummy builtin, everest, and p256m libraries, as these are still expected by some code in mbedtls:development and mbedtls-framework:main.

Once this PR is merged, follow-up PRs against mbedtls:development and mbedtls-framework:main will remove references to the driver libraries. Finally, a cleanup PR against TF-PSA-Crypto:development will remove the dummy driver libraries.

First PR to resolve https://github.com/Mbed-TLS/TF-PSA-Crypto/issues/300.

PR checklist

changelog not required because: the organization in core and driver libraries has not been released.
framework PR not required
mbedtls development PR not required because: this PR can be merged independently, there will be an mbedtls:development follow-up PR though.
mbedtls 3.6 PR not required because: no TF-PSA-Crypto submodule
tests not required because: just changing the build system

## Description The PSA core calls the driver code, and the reverse is also true. Due to these cross-references, they cannot be built into separate libraries, so squash everything into a single one. While this PR moves all the crypto code to the tfpsacrypto library, the last commit adds dummy builtin, everest, and p256m libraries, as these are still expected by some code in mbedtls:development and mbedtls-framework:main. Once this PR is merged, follow-up PRs against mbedtls:development and mbedtls-framework:main will remove references to the driver libraries. Finally, a cleanup PR against TF-PSA-Crypto:development will remove the dummy driver libraries. First PR to resolve https://github.com/Mbed-TLS/TF-PSA-Crypto/issues/300. ## PR checklist - [x] **changelog** not required because: the organization in core and driver libraries has not been released. - [x] **framework PR** not required - [x] **mbedtls development PR** not required because: this PR can be merged independently, there will be an mbedtls:development follow-up PR though. - [x] **mbedtls 3.6 PR** not required because: no TF-PSA-Crypto submodule - **tests** not required because: just changing the build system

valeriosetti (Migrated from github.com) approved these changes

2025-06-26 06:08:18 -05:00

valeriosetti (Migrated from github.com) left a comment

LGTM

minosgalanakis (Migrated from github.com) approved these changes

2025-07-02 09:59:15 -05:00

minosgalanakis (Migrated from github.com) left a comment

Looks good to me.

Just to sum up what this code does

Removes duplicate linking to thread library
Moves windows platform library linking to core
Converts built-in drivers, p256m and everest to object libraries from static libraries.
Add a workaround for CI which adds dummy libraries and hides most of the previous work.

Looks good to me. Just to sum up what this code does - Removes duplicate linking to thread library - Moves windows platform library linking to core - Converts built-in drivers, p256m and everest to object libraries from static libraries. - Add a workaround for CI which adds dummy libraries and hides most of the previous work.

No reviewers

valeriosetti

minosgalanakis

No milestone

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

gh-Mbed-TLS/TF-PSA-Crypto!332

No description provided.

Rows
Columns