Remove deprecated items #372

2025-07-11T03:49:21-05:00

bjwtaylor commented

2025-07-11 03:49:21 -05:00

(Migrated from github.com)

Description

Remove deprecated items, contributes https://github.com/Mbed-TLS/mbedtls/issues/8138

This PR is part of a chain which needs to be merged in the following order:

PR checklist

changelog provided
framework PR not required
mbedtls development PR provided Mbed-TLS/mbedtls https://github.com/Mbed-TLS/mbedtls/pull/10298
mbedtls 3.6 PR not required because: No Backports
tests provided

## Description Remove deprecated items, contributes https://github.com/Mbed-TLS/mbedtls/issues/8138 This PR is part of a chain which needs to be merged in the following order: 1. https://github.com/Mbed-TLS/TF-PSA-Crypto/pull/372 2. https://github.com/Mbed-TLS/mbedtls/pull/10298 ## PR checklist - [ ] **changelog** provided - [ ] **framework PR** not required - [ ] **mbedtls development PR** provided Mbed-TLS/mbedtls https://github.com/Mbed-TLS/mbedtls/pull/10298 - [ ] **mbedtls 3.6 PR** not required because: No Backports - **tests** provided

gilles-peskine-arm (Migrated from github.com) requested changes

2025-07-15 07:11:59 -05:00

gilles-peskine-arm (Migrated from github.com) left a comment

LGTM

There are no more deprecated declarations in /include/mbedtls/*.h. There are still some deprecated private functions but that doesn't matter at this point. There are still some deprecated private functions in /include/psa/*.h, and it would be nice to get rid of them, but let's make this separate tasks: https://github.com/Mbed-TLS/TF-PSA-Crypto/issues/375 https://github.com/Mbed-TLS/TF-PSA-Crypto/issues/376

LGTM There are no more deprecated declarations in `/include/mbedtls/*.h`. There are still some deprecated private functions but that doesn't matter at this point. There are still some deprecated private functions in `/include/psa/*.h`, and it would be nice to get rid of them, but let's make this separate tasks: https://github.com/Mbed-TLS/TF-PSA-Crypto/issues/375 https://github.com/Mbed-TLS/TF-PSA-Crypto/issues/376

include/mbedtls/asn1.h

					
				@ -595,22 +595,6 @@ int mbedtls_asn1_get_alg_null(unsigned char **p,

				const mbedtls_asn1_named_data *mbedtls_asn1_find_named_data(const mbedtls_asn1_named_data *list,

				                                                            const char *oid, size_t len);

Please add a changelog entry under “Removals”.

gilles-peskine-arm (Migrated from github.com) requested changes

2025-07-17 12:17:46 -05:00

gilles-peskine-arm (Migrated from github.com) left a comment

LGTM except the changelog entry

ChangeLog.d/remove-deprecated-items.txt

					
				@ -0,0 +1,4 @@

				Removals

Missing full stop at the end of the sentence. Also we like to put () after function names in the changelog.

   * Remove mbedtls_asn1_free_named_data(). Use
     mbedtls_asn1_free_named_data_list() or
     mbedtls_asn1_free_named_data_list_shallow() instead.

Missing full stop at the end of the sentence. Also we like to put () after function names in the changelog. ```suggestion * Remove mbedtls_asn1_free_named_data(). Use mbedtls_asn1_free_named_data_list() or mbedtls_asn1_free_named_data_list_shallow() instead. ```