gh-Mbed-TLS/TF-PSA-Crypto

Watch

Fork 0

Fix a build failure that occurs in environments using Code Page 950 #411

Open

aphroteus wants to merge 1 commit from aphroteus/development into development

aphroteus commented

2025-08-06 22:56:57 -05:00

(Migrated from github.com)

Replace a non-ASCII character with a space

Description

A build error message was found:
ecdh.h(1): error C2220: the following warning is treated as an error
ecdh.h(1): warning C4819: The file contains a character that cannot be represented in the current code page (950). Save the file in Unicode format to prevent data loss

PR checklist

Please remove the segment/s on either side of the | symbol as appropriate, and add any relevant link/s to the end of the line.
If the provided content is part of the present PR remove the # symbol.

changelog provided | not required because: no change in functionality
framework PR provided Mbed-TLS/mbedtls-framework# | not required
mbedtls development PR provided Mbed-TLS/mbedtls# | not required because: file doesn't exist
mbedtls 3.6 PR provided https://github.com/Mbed-TLS/mbedtls/pull/10347
tests provided | not required because: no change in functionality

Notes for the submitter

Please refer to the contributing guidelines, especially the
checklist for PR contributors.

Help make review efficient:

Multiple simple commits
- please structure your PR into a series of small commits, each of which does one thing
Avoid force-push
- please do not force-push to update your PR - just add new commit(s)
See our Guidelines for Contributors for more details about the review process.

Replace a non-ASCII character with a space ## Description A build error message was found: **_ecdh.h(1): error C2220: the following warning is treated as an error ecdh.h(1): warning C4819: The file contains a character that cannot be represented in the current code page (950). Save the file in Unicode format to prevent data loss_** ## PR checklist Please remove the segment/s on either side of the | symbol as appropriate, and add any relevant link/s to the end of the line. If the provided content is part of the present PR remove the # symbol. - [x] **changelog** provided | not required because: no change in functionality - [X] **framework PR** provided Mbed-TLS/mbedtls-framework# | not required - [X] **mbedtls development PR** provided Mbed-TLS/mbedtls# | not required because: file doesn't exist - [X] **mbedtls 3.6 PR** provided https://github.com/Mbed-TLS/mbedtls/pull/10347 - **tests** provided | not required because: no change in functionality ## Notes for the submitter Please refer to the [contributing guidelines](https://github.com/Mbed-TLS/TF-PSA-Crypto/blob/development/CONTRIBUTING.md), especially the checklist for PR contributors. Help make review efficient: * Multiple simple commits - please structure your PR into a series of small commits, each of which does one thing * Avoid force-push - please do not force-push to update your PR - just add new commit(s) * See our [Guidelines for Contributors](https://mbed-tls.readthedocs.io/en/latest/reviews/review-for-contributors/) for more details about the review process.

This pull request has changes conflicting with the target branch.

drivers/builtin/include/mbedtls/ecdh.h

View command line instructions

Manual merge helper

Use this merge commit message when completing the merge manually.

Merge commit title

Merge pull request 'Fix a build failure that occurs in environments using Code Page 950' (#411) from aphroteus/development into development

Merge commit body

Reviewed-on: https://git.richey.dev/gh-Mbed-TLS/TF-PSA-Crypto/pulls/411

Merge pull request 'Fix a build failure that occurs in environments using Code Page 950' (#411) from aphroteus/development into development

Reviewed-on: https://git.richey.dev/gh-Mbed-TLS/TF-PSA-Crypto/pulls/411

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin 'aphroteus/development:aphroteus/development'

git switch 'aphroteus/development'

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch 'development'

git merge --no-ff 'aphroteus/development'

git switch 'aphroteus/development'

git rebase 'development'

git switch 'development'

git merge --ff-only 'aphroteus/development'

git switch 'aphroteus/development'

git rebase 'development'

git switch 'development'

git merge --no-ff 'aphroteus/development'

git switch 'development'

git merge --squash 'aphroteus/development'

git switch 'development'

git merge --ff-only 'aphroteus/development'

git switch 'development'

git merge 'aphroteus/development'

git push origin 'development'

No reviewers

No milestone

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

gh-Mbed-TLS/TF-PSA-Crypto!411

No description provided.

Rows
Columns