gh-Mbed-TLS/TF-PSA-Crypto
Watch
1
0
Fork
You've already forked TF-PSA-Crypto
 0
Code Issues 167 Pull requests 92 Releases 5 Activity

Use GNUIstalldir CMAKE_INSTALL_INCLUDEDIR for headers installation #547

Merged
Begasus merged 1 commit from includedir into development 2025-10-29 12:21:01 -05:00
Conversation 4 Commits 1 Files changed 5 +9 -6
Begasus commented 2025-10-23 10:48:10 -05:00 (Migrated from github.com)

Description

Using a hardcoded path like "include" for headers path doesn't follow GNUInstallDirs method.
This is a follow up for building/packaging mbedtls 4.0.0 on Haiku

PR checklist

  • changelog provided
  • framework PR not required
  • mbedtls development PR provided Mbed-TLS/mbedtls#10469
  • mbedtls 3.6 PR provided Mbed-TLS/mbedtls#10470
  • tests not required because: The installation process is exercised by programs/test/cmake_package_install.
## Description Using a hardcoded path like "include" for headers path doesn't follow GNUInstallDirs method. This is a follow up for building/packaging mbedtls 4.0.0 on Haiku ## PR checklist - [x] **changelog** provided - [x] **framework PR** not required - [x] **mbedtls development PR** provided Mbed-TLS/mbedtls#10469 - [x] **mbedtls 3.6 PR** provided Mbed-TLS/mbedtls#10470 - **tests** not required because: The installation process is exercised by programs/test/cmake_package_install.
Begasus commented 2025-10-23 10:52:19 -05:00 (Migrated from github.com)

Fixes: https://github.com/Mbed-TLS/TF-PSA-Crypto/issues/545

Fixes: https://github.com/Mbed-TLS/TF-PSA-Crypto/issues/545
ronald-cron-arm (Migrated from github.com) approved these changes 2025-10-24 11:33:01 -05:00
ronald-cron-arm (Migrated from github.com) left a comment

LGTM, thanks.

LGTM, thanks.
minosgalanakis (Migrated from github.com) approved these changes 2025-10-29 10:06:32 -05:00
minosgalanakis (Migrated from github.com) left a comment

LGTM

LGTM
Begasus commented 2025-10-29 13:07:43 -05:00 (Migrated from github.com)

Thanks! 👍

Thanks! :+1:
Sign in to join this conversation.
Reviewers
No reviewers
ronald-cron-arm
minosgalanakis
Labels
Clear labels   
api-break
This issue/PR breaks the API and must wait for a new major version

  
approved
Design and code approved - may be waiting for CI or backports

  
bug
Something isn't working

  
component-docs
Docs / website issues filed here for tracking

  
component-platform
Portability layer and build scripts

  
component-test
Test framework and CI scripts

  
dependencies
Pull requests that update a dependency file

  
deprecation
needs deprecation announcement

  
DO-NOT-MERGE

   
enhancement
New feature or request

  
good first issue
Good for newcomers

  
help wanted
This issue is not being actively worked on, but PRs welcome.

  
needs-adoption
stalled PR that someone should pick up and complete

  
needs-backports
Backports are missing or are pending review and approval.

  
needs-ci
Needs to pass CI tests

  
needs-design-approval
Needs design discussion / approval

  
needs-info
An issue or PR which needs further info from the reporter / author

  
needs-preceding-pr
Requires another PR to be merged first

  
needs-review
Every commit must be reviewed by at least two team members

  
needs-reviewer
This PR needs someone to pick it up for review

  
needs-work

   
priority-high
High priority - will be reviewed soon

  
priority-low
Low priority - this may not receive review soon

  
priority-medium
Medium priority - this can be reviewed as time permits

  
priority-scheduled
This PR is big - it will require time to be scheduled for review

  
priority-very-high
Highest priority - prioritise this over other review work

  
resolved-after-1.1
The issue is resolved in development, but still present in 1.1 LTS.

  
single-reviewer
This PR qualifies for having only one reviewer

  
size-l
Estimated task size: large (2w+)

  
size-m
Estimated task size: medium (~1w)

  
size-optimisation

   
size-s
Estimated task size: small (~2d)

  
size-xs
Estimated task size: extra small (a few hours at most)

No labels
api-break
approved
bug
component-docs
component-platform
component-test
dependencies
deprecation
DO-NOT-MERGE
enhancement
good first issue
help wanted
needs-adoption
needs-backports
needs-ci
needs-design-approval
needs-info
needs-preceding-pr
needs-review
needs-reviewer
needs-work
priority-high
priority-low
priority-medium
priority-scheduled
priority-very-high
resolved-after-1.1
single-reviewer
size-l
size-m
size-optimisation
size-s
size-xs
Milestone
Clear milestone
No items
No milestone
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
gh-Mbed-TLS/TF-PSA-Crypto!547
No description provided.