fix error in GCC bswap #649

Merged

daverodgman merged 1 commit from gcc_bswap_fix into development

2026-02-11 10:08:45 -06:00

daverodgman commented

2026-01-12 04:24:01 -06:00

(Migrated from github.com)

Description

The gcc detection for some reason depended on __GNUC_PREREQ, which was undefined (AIUI it comes from a header which isn't included here). Replace with MBEDTLS_GCC_VERSION.

Presumably size & performance-affecting (I haven't properly measured, but observed eg 17% improvement from this patch in benchmark ctr_drbg) but not a functional change. Improves AES-GCM by around 20-25%.

PR checklist

Please remove the segment/s on either side of the | symbol as appropriate, and add any relevant link/s to the end of the line.
If the provided content is part of the present PR remove the # symbol.

changelog not required because: no functional change
framework PR not affected
mbedtls development PR this PR
mbedtls 3.6 PR https://github.com/Mbed-TLS/mbedtls/pull/10589
tests not required because: already tested / no functional change

## Description The gcc detection for some reason depended on `__GNUC_PREREQ`, which was undefined (AIUI it comes from a header which isn't included here). Replace with `MBEDTLS_GCC_VERSION`. Presumably size & performance-affecting (I haven't properly measured, but observed eg 17% improvement from this patch in `benchmark ctr_drbg`) but not a functional change. Improves AES-GCM by around 20-25%. ## PR checklist Please remove the segment/s on either side of the | symbol as appropriate, and add any relevant link/s to the end of the line. If the provided content is part of the present PR remove the # symbol. - [x] **changelog** not required because: no functional change - [x] **framework PR** not affected - [x] **mbedtls development PR** this PR - [x] **mbedtls 3.6 PR** https://github.com/Mbed-TLS/mbedtls/pull/10589 - [x] **tests** not required because: already tested / no functional change

gilles-peskine-arm (Migrated from github.com) approved these changes

2026-01-13 09:54:26 -06:00

gilles-peskine-arm (Migrated from github.com) left a comment

Thanks, LGTM with some very casual look at Godbolt

Thanks, LGTM with some very casual look at [Godbolt](https://godbolt.org/#z:OYLghAFBqRAWIDGB7AJgUwKKoJYBdkAnAGhxAgDMcAbdAOwEMBbdEAcgEY3iLk68Ayoga0QHACw8%2BeAKoBndAAUAHuwAM3AFZji1BnVAB9Y4mILaiPDj7l6qAMLJqAVyZ0QANkl2AMjjroAHKuAEbohGIATBzEAA7IcvjWdI4ubp6S8YlWfH4BwUxhERzRZugWOXQCeAyEeKmu7l5lFcnVtXh5QaHhUTFyNXUN6c0DHV0FRX0AlGbIzoSIrGwApJEAzP6ILhgA1Cvr9tQ4TPhyAHRwB5gragCCa5t02857B/YDuPyX17cPG1sduh9odPscQj91jd7o9Aa9ge9PtZIdCHjCARRdhgqAFUBBjABxQIyezGab7SIeNYeXZgMDY/zoPHGO4AJQAsvZSQA1TCsgQASQA8oFydTqbT6egcUz8YZtvpgGT9gBWex/XaailUymShm4uXUagANyYyvFurp%2BtlxgFgQAKpgfIZ7EL2YoBT4%2BdM/gB6ABUuwAItLGahdjhMXg4MCUExYjRwrtCOgRNQAJ4RuS7YCIRC7fThujIPC7BUGYi7dB4fP%2B31/R7W3bsgBCmCD9p8Ahdbo9XtZhgF3YJXIbGybrfbneHXMMvP5wsCqvV9y1uzlRJJxl2gY4an3agpLd2hOJpPZdqFA8MO92e8Pa2Pp63iju9vsAAkvbznYYfej1jsSMG3uAMNUDEM8HQSxdhHexdhCZwaDwABafwEPTKC5AAdwYWJk3mKwAjkcD6wAyMsVDA1n1JP8x02TFJw7LtDDguc%2BUFEUQRudYg12cQ1AADn3eiJzbZjuxbAQAHU7kUDgaWMRDkP8QwQhwvCFPooCKHoiimOnVjZ3nTil1%2BXj%2BLUdYRIAsSpxYqTZMUdZIhPNSkOoIi1I02IXNEqjgQMhyZLkrw3OUzzVPU3DYi8bS6FwXSAJ03YA0omVmVYs9lTrEC7jA1cIOraDSyORUEI81D0JCTD0B8gjnCIurSL0zFrUy8slT/bUJXauU4AYOR3JUuh/3%2BBi3IGoaIqIuUZqinyFLFSkJStAK8SCySQvkjwxsbALm3EwzHLkhTwsqhaYq05KEootLjCm4bIroOaLrobyrt2ncyPGiiHsGp7ZqUt6Prwlzlp1Gk1oyiBNsME7nMiPbxwOuGEZc86RtB3zInixLUsDf7pre16seisGke%2B1rJoB%2BaXuBsmfK8CHVqlGG0e25n/JlQ77K2pywoZ57sbim78fuwxHrp0nhfJ2LxHJXKxbuwM%2BpMPQDHNFbdTVyXabexWfr9f1wODYqYPZARuXgma0LoDCsJihqmpIwqjYxdKw3xS2eW9anoa9jmnKW7nGV5iT4e2s61NqnzDGcOQ4CIPA8eA8jMQDg0g7k8HQ4CcPju2jGY8dvD4%2BoPhgFTpLfoztnA6O4KBYVvPAsb/nQvEE8atL2J4/8PBRfGnTq4Jz3qJ99jWUNvK0sgkqC0IJg8wq5C7YduqncIQiw6V2vx5tQw2U5X2FxFFndTlY/jI4xduIOPjxHvfcL6h%2Bus/byOnNz9OD8y4%2Bj72C9OSMex9diOHjImQguwaQoSrLUY4SZjThESHwbMqA%2BBgDYKWAITICy7BjAwDA0C96wmeECEE9hahmgYNsdAKJq6twLk3HOrljApmNIwmEoEipQRggKNkq9PLrx7pvPCztd7uwmrrARA4BAAE0BCOktoOWcdFf66wAXcIBmBkZPBeG8Q41DDC0NoAw2yqNP4IwUhAZQ5IoBIX4ApQweByTsPQMaGxEBHF4Bci4%2Bxdjph6LshHdGbDDAcKYdnRQgsIkeKNFw4et0a7G1NtJGMKYyzIEgbQaBtt/DZlqMCYspZYgpgUPwSsFA0wIVoQAa12AQcBWS9jRgYKWaM6BTZxgTLk3YTAGCZjCAWEItBGnIEonw0shZGmEH0HIXgS8Iz8AmZ05M5QPH6FLHLXYRBTaJFOHoaBBS8CEGcJYZI5wWq/0zrKaJId7hjCsPmfwxx84%2BOcaWQoTI8DUGmotDw3iB6fN2HYhsAB2FsGotQpjwAsOg0K1yalsdqXYahlD7goBQMUhx3i7EEvscFK47hIq1CiiU6KsUv3vlCfFBwoUwnBUGKJVio40m%2BagX5/zPqjzSrcjarLg5fVITc9%2BdzBWsLGk8nALy6BvOBD4vxXywicr%2BdjFyQL%2BBKtBXtSFiL1lwsIAi1cpL1zKFReig8B4sU4vVIcXYkQu4rCJfqtc5LdSWutRQal7w8X4sJcS01ZqLUYrUFSg8OKeKYE1AS51gbTXuppJS71Vq1CRuuA68Q9KIXMosTzaJGMOVcvVbjZWmI%2BVioFXzL%2BkqqbcP3vy2GEqYkt0eTUZ5yz5W7B8V4Fx/SVXFrll4TVg9xB9rBYyhlJKYXVnha6sl5qKWhtTSusNFAZA%2BB8LavFKoaRxvncixdHrl2rsxSmjdW7KF4oEgGg9wal2nrPVai9277WOtvSa0lia0UnqteG59m7X3wX9fuz9SLv2er/SmldL6aXRpAy6sDbqj1JpPf%2B1dsHzLRvfaB6dX6UM/qfY%2B/cmGoQZpvbhoNEHlDoeI6RqNuxd3ZsZbm8aITC7N37T8tVQ6s1lrHo26JzM61ojuAPfpDB/AQDFHqsDHyPDjrOg/Qje5IjOCPAWAgOBoDFToMaCAaxIivntB%2BQzQTmN4e7QPbVygMbKctapqyahxDOGoBp9pyBtPAF0/pwzxnTORCRj6dYU61w9rHaWZQYV7MYsc9ZASKo1AeDUOCoSrm3OPk055nTUE9MGcC/5szwXQtank329MSmLL3MBcoEOIX9WKsiOVuzVXm0ats0jCzYWB69tLOmaLrXq0I2HVFlu9WwNlIHhQfLuNIiJfEOalCGa1jzeUCsNUCLAuVm8XQRIwBcTTFqx4bbzhds4H20yaYFXdpda1JN/g03DMraEtQRby25svbWxtwzJ2zsXfDBXAwh2XK/b27iXYgPgBXdzuNyz928CPcC89hSRo3u0uRx4VH637CbciKD874PIcQ8rod5o65Ttg7wUTyHV2uaw7XLC%2BFaKLPOtY2wWY1B2Aqm4O4NgGhiDIHYPBOQ8xFgIg2FwYgeB1Ds%2BIPAJA2TenhFIOQHpUCkDAHEIJGIVBPIoPICEGXxAQj%2BFqOmdgkuTeMEIOmIUIRNAlQt9wOMLB%2BBCjlebvn3AMCIWAFQo0cgnfEAwAMgwogvfB5wCmC5yDA8R/QMoaCjVlj84HuUI34I5k28cBgI3pyThB%2BQYQEICR0AhlD8AN5oAvezAoHoYAchuQ4HQNhIUsR6BB94PwIQIhWASCkPweQShVAR%2B0DEDWRgTC6BwOpcA0mBexEqHHlC0kakr4T6chguwUJCkiNwZARfCA4AwIHyAsxzAlWSLYBKwx3AxF8IySYvQYhZCSHwW/OhX%2BVAmD0YoLRL98DtBDBOCNA6AX4XKAGDCdCP6/5gFQEf79BQE/7fLFDn6i5LBiAc5c485G6C5sCgqCQeAoRhS5j5jiDnCCTnAcDrjYD4BEAUjrAcDTDcDS415y4ICESxCNQq4QBq65KBDMDLDKCEHEFdykF3gqjnB77EBMh0FH6oA6Bd6CDCCiD95KFD4qBG5j7EDYRzKxBO5YFsDc7EC87854FCiNRcGljICYjCFEEkErzkGUHUEQAQJK7QKPBMEsEy5BLEB1JiD7jnDEYHjj7sDiDcBMABFqAmG4HsDcCB4xCsEaC%2BFF6oLuDiBAA%3D)

davidhorstmann-arm (Migrated from github.com) approved these changes

2026-02-10 11:20:49 -06:00

davidhorstmann-arm (Migrated from github.com) left a comment

LGTM, thanks!

davidhorstmann-arm commented

2026-02-10 11:22:52 -06:00

(Migrated from github.com)

Sorry about this, the CI is failing because we've moved PSASIM (it was passing but I accidentally retriggered it while trying to start the other one - my bad). Would you mind rebasing this PR on the latest development? (The 3.6 PR is fine as-is.)

No reviewers

gilles-peskine-arm

davidhorstmann-arm

No milestone

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

gh-Mbed-TLS/TF-PSA-Crypto!649

No description provided.

Rows
Columns