gh-Mbed-TLS/TF-PSA-Crypto
Watch
1
0
Fork
You've already forked TF-PSA-Crypto
 0
Code Issues 167 Pull requests 92 Releases 5 Activity

Fixed clang arm intrinsics for older compiler versions #663

Merged
minosgalanakis merged 1 commit from bugfix/fix-intrisic-aesce-clang into development 2026-02-11 07:43:12 -06:00
Conversation 2 Commits 1 Files changed 1 +5 -1
minosgalanakis commented 2026-01-15 09:20:04 -06:00 (Migrated from github.com)

Description

Resolves #660

PR checklist

Please remove the segment/s on either side of the | symbol as appropriate, and add any relevant link/s to the end of the line.
If the provided content is part of the present PR remove the # symbol.

  • changelog provided | not required because:
  • framework PR not required
  • mbedtls development PR not required because: The file only resides on this repository
  • mbedtls 3.6 PR provided Mbed-TLS/mbedtls#10565
  • tests not required because: TODO
## Description Resolves #660 ## PR checklist Please remove the segment/s on either side of the | symbol as appropriate, and add any relevant link/s to the end of the line. If the provided content is part of the present PR remove the # symbol. - [ ] **changelog** provided | not required because: - [ ] **framework PR** not required - [ ] **mbedtls development PR** not required because: The file only resides on this repository - [ ] **mbedtls 3.6 PR** provided Mbed-TLS/mbedtls#10565 - **tests** not required because: TODO
gilles-peskine-arm (Migrated from github.com) approved these changes 2026-02-10 10:36:52 -06:00
gilles-peskine-arm (Migrated from github.com) left a comment

Makes sense to me: llc-6.0 -march=aarch64 -mattr=help lists crypto but not aes, and llc-7 -march=aarch64 -mattr=help lists both. And for aarch64_32, according to the checks above, you need Clang ≥11, and llc-11 -march=aarch64_32 -mattr=help lists both aes and crypto.

Makes sense to me: `llc-6.0 -march=aarch64 -mattr=help` lists `crypto` but not `aes`, and `llc-7 -march=aarch64 -mattr=help` lists both. And for aarch64_32, according to the checks above, you need Clang ≥11, and `llc-11 -march=aarch64_32 -mattr=help` lists both `aes` and `crypto`.
davidhorstmann-arm (Migrated from github.com) approved these changes 2026-02-11 05:53:32 -06:00
davidhorstmann-arm (Migrated from github.com) left a comment

LGTM, thanks!

LGTM, thanks!
Sign in to join this conversation.
Reviewers
No reviewers
gilles-peskine-arm
davidhorstmann-arm
Labels
Clear labels   
api-break
This issue/PR breaks the API and must wait for a new major version

  
approved
Design and code approved - may be waiting for CI or backports

  
bug
Something isn't working

  
component-docs
Docs / website issues filed here for tracking

  
component-platform
Portability layer and build scripts

  
component-test
Test framework and CI scripts

  
dependencies
Pull requests that update a dependency file

  
deprecation
needs deprecation announcement

  
DO-NOT-MERGE

   
enhancement
New feature or request

  
good first issue
Good for newcomers

  
help wanted
This issue is not being actively worked on, but PRs welcome.

  
needs-adoption
stalled PR that someone should pick up and complete

  
needs-backports
Backports are missing or are pending review and approval.

  
needs-ci
Needs to pass CI tests

  
needs-design-approval
Needs design discussion / approval

  
needs-info
An issue or PR which needs further info from the reporter / author

  
needs-preceding-pr
Requires another PR to be merged first

  
needs-review
Every commit must be reviewed by at least two team members

  
needs-reviewer
This PR needs someone to pick it up for review

  
needs-work

   
priority-high
High priority - will be reviewed soon

  
priority-low
Low priority - this may not receive review soon

  
priority-medium
Medium priority - this can be reviewed as time permits

  
priority-scheduled
This PR is big - it will require time to be scheduled for review

  
priority-very-high
Highest priority - prioritise this over other review work

  
resolved-after-1.1
The issue is resolved in development, but still present in 1.1 LTS.

  
single-reviewer
This PR qualifies for having only one reviewer

  
size-l
Estimated task size: large (2w+)

  
size-m
Estimated task size: medium (~1w)

  
size-optimisation

   
size-s
Estimated task size: small (~2d)

  
size-xs
Estimated task size: extra small (a few hours at most)

No labels
api-break
approved
bug
component-docs
component-platform
component-test
dependencies
deprecation
DO-NOT-MERGE
enhancement
good first issue
help wanted
needs-adoption
needs-backports
needs-ci
needs-design-approval
needs-info
needs-preceding-pr
needs-review
needs-reviewer
needs-work
priority-high
priority-low
priority-medium
priority-scheduled
priority-very-high
resolved-after-1.1
single-reviewer
size-l
size-m
size-optimisation
size-s
size-xs
Milestone
Clear milestone
No items
No milestone
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
gh-Mbed-TLS/TF-PSA-Crypto!663
No description provided.