gh-Mbed-TLS/TF-PSA-Crypto
Watch
1
0
Fork
You've already forked TF-PSA-Crypto
 0
Code Issues 167 Pull requests 92 Releases 5 Activity

Only build mbedtls_rsa_deduce_private_exponent when key generation is enabled #673

Open
valeriosetti wants to merge 4 commits from valeriosetti/issue669 into development
pull from: valeriosetti/issue669
merge into: gh-Mbed-TLS:development
Conversation 4 Commits 4 Files changed 7 +250 -235
valeriosetti commented 2026-01-22 04:43:44 -06:00 (Migrated from github.com)

Description

Resolves #669

PR checklist

  • changelog not required because: mbedtls_rsa_deduce_private_exponent in an internal function so adding a guard to it is not something visible to the user.
  • framework PR not required
  • mbedtls development PR not required because: no change there
  • mbedtls 3.6 PR not required because: no backport
  • tests provided: updated as requested in the issue
## Description Resolves #669 ## PR checklist - [ ] **changelog** not required because: `mbedtls_rsa_deduce_private_exponent` in an internal function so adding a guard to it is not something visible to the user. - [ ] **framework PR** not required - [ ] **mbedtls development PR** not required because: no change there - [ ] **mbedtls 3.6 PR** not required because: no backport - **tests** provided: updated as requested in the issue
bjwtaylor (Migrated from github.com) reviewed 2026-01-26 07:11:03 -06:00
bjwtaylor commented 2026-07-20 02:43:13 -05:00 (Migrated from github.com)

The CI looks broken, is this expected?

The CI looks broken, is this expected?
valeriosetti commented 2026-07-29 03:40:45 -05:00 (Migrated from github.com)

The CI looks broken, is this expected?

Nope, there was a problem with the last minute rebase that I did to resolve a conflict on the RSA test data before leaving for vacations. Now it should be fixed. Let's see what the CI thinks. Once it's happy I will ping you again.

> The CI looks broken, is this expected? Nope, there was a problem with the last minute rebase that I did to resolve a conflict on the RSA test data before leaving for vacations. Now it should be fixed. Let's see what the CI thinks. Once it's happy I will ping you again.
bjwtaylor (Migrated from github.com) approved these changes 2026-07-29 05:16:24 -05:00
This pull request is broken due to missing fork information.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin 'valeriosetti/issue669:valeriosetti/issue669'
git switch 'valeriosetti/issue669'

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch 'development'
git merge --no-ff 'valeriosetti/issue669'
git switch 'valeriosetti/issue669'
git rebase 'development'
git switch 'development'
git merge --ff-only 'valeriosetti/issue669'
git switch 'valeriosetti/issue669'
git rebase 'development'
git switch 'development'
git merge --no-ff 'valeriosetti/issue669'
git switch 'development'
git merge --squash 'valeriosetti/issue669'
git switch 'development'
git merge --ff-only 'valeriosetti/issue669'
git switch 'development'
git merge 'valeriosetti/issue669'
git push origin 'development'
Sign in to join this conversation.
Reviewers
No reviewers
bjwtaylor
Labels
Clear labels   
api-break
This issue/PR breaks the API and must wait for a new major version

  
approved
Design and code approved - may be waiting for CI or backports

  
bug
Something isn't working

  
component-docs
Docs / website issues filed here for tracking

  
component-platform
Portability layer and build scripts

  
component-test
Test framework and CI scripts

  
dependencies
Pull requests that update a dependency file

  
deprecation
needs deprecation announcement

  
DO-NOT-MERGE

   
enhancement
New feature or request

  
good first issue
Good for newcomers

  
help wanted
This issue is not being actively worked on, but PRs welcome.

  
needs-adoption
stalled PR that someone should pick up and complete

  
needs-backports
Backports are missing or are pending review and approval.

  
needs-ci
Needs to pass CI tests

  
needs-design-approval
Needs design discussion / approval

  
needs-info
An issue or PR which needs further info from the reporter / author

  
needs-preceding-pr
Requires another PR to be merged first

  
needs-review
Every commit must be reviewed by at least two team members

  
needs-reviewer
This PR needs someone to pick it up for review

  
needs-work

   
priority-high
High priority - will be reviewed soon

  
priority-low
Low priority - this may not receive review soon

  
priority-medium
Medium priority - this can be reviewed as time permits

  
priority-scheduled
This PR is big - it will require time to be scheduled for review

  
priority-very-high
Highest priority - prioritise this over other review work

  
resolved-after-1.1
The issue is resolved in development, but still present in 1.1 LTS.

  
single-reviewer
This PR qualifies for having only one reviewer

  
size-l
Estimated task size: large (2w+)

  
size-m
Estimated task size: medium (~1w)

  
size-optimisation

   
size-s
Estimated task size: small (~2d)

  
size-xs
Estimated task size: extra small (a few hours at most)

No labels
api-break
approved
bug
component-docs
component-platform
component-test
dependencies
deprecation
DO-NOT-MERGE
enhancement
good first issue
help wanted
needs-adoption
needs-backports
needs-ci
needs-design-approval
needs-info
needs-preceding-pr
needs-review
needs-reviewer
needs-work
priority-high
priority-low
priority-medium
priority-scheduled
priority-very-high
resolved-after-1.1
single-reviewer
size-l
size-m
size-optimisation
size-s
size-xs
Milestone
Clear milestone
No items
No milestone
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
gh-Mbed-TLS/TF-PSA-Crypto!673
No description provided.