gh-Mbed-TLS/TF-PSA-Crypto
Watch
1
0
Fork
You've already forked TF-PSA-Crypto
 0
Code Issues 167 Pull requests 92 Releases 5 Activity

Bump cmake min and remove related conditionals #915

Open
jfdev001 wants to merge 1 commit from jfdev001/bump-cmake-minimum-version into development
pull from: jfdev001/bump-cmake-minimum-version
merge into: gh-Mbed-TLS:development
Conversation 0 Commits 1 Files changed 1 +9 -20
jfdev001 commented 2026-09-23 09:16:04 -05:00 (Migrated from github.com)

Description

Change cmake minimum required version to correspond to README.

Remove conditionals that are no longer valid.

Related to https://github.com/Mbed-TLS/TF-PSA-Crypto/issues/913

PR checklist

Please remove the segment/s on either side of the | symbol as appropriate, and add any relevant link/s to the end of the line.
If the provided content is part of the present PR remove the # symbol.

  • changelog provided | not required because: minor changes only
  • framework PR not required
  • TF-PSA-Crypto development PR
  • TF-PSA-Crypto 1.1 PR provided | https://github.com/Mbed-TLS/TF-PSA-Crypto/pull/916
  • mbedtls development PR | TODO: Requires current PR to be merged and then can update submodule commit
  • mbedtls 4.1 PR | TODO: Requires https://github.com/Mbed-TLS/TF-PSA-Crypto/pull/916 and then can update submodule commit
  • mbedtls 3.6 PR | not required because: No submodule pointing to TF-PSA-Crypto
  • tests not required because: minor changes only

Notes for the submitter

Please refer to the contributing guidelines, especially the
checklist for PR contributors.

Help make review efficient:

  • Multiple simple commits
    • please structure your PR into a series of small commits, each of which does one thing
  • Avoid force-push
    • please do not force-push to update your PR - just add new commit(s)
  • See our Guidelines for Contributors for more details about the review process.
## Description Change cmake minimum required version to correspond to README. Remove conditionals that are no longer valid. Related to https://github.com/Mbed-TLS/TF-PSA-Crypto/issues/913 ## PR checklist Please remove the segment/s on either side of the | symbol as appropriate, and add any relevant link/s to the end of the line. If the provided content is part of the present PR remove the # symbol. - [x] **changelog** provided | not required because: minor changes only - [x] **framework PR** not required - [x] **TF-PSA-Crypto development PR** - [X] **TF-PSA-Crypto 1.1 PR** provided | https://github.com/Mbed-TLS/TF-PSA-Crypto/pull/916 - [ ] **mbedtls development PR** | TODO: Requires current PR to be merged and then can update submodule commit - [ ] **mbedtls 4.1 PR** | TODO: Requires https://github.com/Mbed-TLS/TF-PSA-Crypto/pull/916 and then can update submodule commit - [X] **mbedtls 3.6 PR** | not required because: No submodule pointing to TF-PSA-Crypto - **tests** not required because: minor changes only ## Notes for the submitter Please refer to the [contributing guidelines](https://github.com/Mbed-TLS/TF-PSA-Crypto/blob/development/CONTRIBUTING.md), especially the checklist for PR contributors. Help make review efficient: * Multiple simple commits - please structure your PR into a series of small commits, each of which does one thing * Avoid force-push - please do not force-push to update your PR - just add new commit(s) * See our [Guidelines for Contributors](https://mbed-tls.readthedocs.io/en/latest/reviews/review-for-contributors/) for more details about the review process.
This pull request is broken due to missing fork information.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin 'jfdev001/bump-cmake-minimum-version:jfdev001/bump-cmake-minimum-version'
git switch 'jfdev001/bump-cmake-minimum-version'

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch 'development'
git merge --no-ff 'jfdev001/bump-cmake-minimum-version'
git switch 'jfdev001/bump-cmake-minimum-version'
git rebase 'development'
git switch 'development'
git merge --ff-only 'jfdev001/bump-cmake-minimum-version'
git switch 'jfdev001/bump-cmake-minimum-version'
git rebase 'development'
git switch 'development'
git merge --no-ff 'jfdev001/bump-cmake-minimum-version'
git switch 'development'
git merge --squash 'jfdev001/bump-cmake-minimum-version'
git switch 'development'
git merge --ff-only 'jfdev001/bump-cmake-minimum-version'
git switch 'development'
git merge 'jfdev001/bump-cmake-minimum-version'
git push origin 'development'
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
api-break
This issue/PR breaks the API and must wait for a new major version

  
approved
Design and code approved - may be waiting for CI or backports

  
bug
Something isn't working

  
component-docs
Docs / website issues filed here for tracking

  
component-platform
Portability layer and build scripts

  
component-test
Test framework and CI scripts

  
dependencies
Pull requests that update a dependency file

  
deprecation
needs deprecation announcement

  
DO-NOT-MERGE

   
enhancement
New feature or request

  
good first issue
Good for newcomers

  
help wanted
This issue is not being actively worked on, but PRs welcome.

  
needs-adoption
stalled PR that someone should pick up and complete

  
needs-backports
Backports are missing or are pending review and approval.

  
needs-ci
Needs to pass CI tests

  
needs-design-approval
Needs design discussion / approval

  
needs-info
An issue or PR which needs further info from the reporter / author

  
needs-preceding-pr
Requires another PR to be merged first

  
needs-review
Every commit must be reviewed by at least two team members

  
needs-reviewer
This PR needs someone to pick it up for review

  
needs-work

   
priority-high
High priority - will be reviewed soon

  
priority-low
Low priority - this may not receive review soon

  
priority-medium
Medium priority - this can be reviewed as time permits

  
priority-scheduled
This PR is big - it will require time to be scheduled for review

  
priority-very-high
Highest priority - prioritise this over other review work

  
resolved-after-1.1
The issue is resolved in development, but still present in 1.1 LTS.

  
single-reviewer
This PR qualifies for having only one reviewer

  
size-l
Estimated task size: large (2w+)

  
size-m
Estimated task size: medium (~1w)

  
size-optimisation

   
size-s
Estimated task size: small (~2d)

  
size-xs
Estimated task size: extra small (a few hours at most)

No labels
api-break
approved
bug
component-docs
component-platform
component-test
dependencies
deprecation
DO-NOT-MERGE
enhancement
good first issue
help wanted
needs-adoption
needs-backports
needs-ci
needs-design-approval
needs-info
needs-preceding-pr
needs-review
needs-reviewer
needs-work
priority-high
priority-low
priority-medium
priority-scheduled
priority-very-high
resolved-after-1.1
single-reviewer
size-l
size-m
size-optimisation
size-s
size-xs
Milestone
Clear milestone
No items
No milestone
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
gh-Mbed-TLS/TF-PSA-Crypto!915
No description provided.