gh-Mbed-TLS/mbedtls-framework
Watch
1
0
Fork
You've already forked mbedtls-framework
 0
Code Issues 39 Pull requests 42 Releases Activity

Use a null pointer for empty data #177

Open
gilles-peskine-arm wants to merge 1 commit from gilles-peskine-arm/test-data_t-empty_is_empty-framework into main
pull from: gilles-peskine-arm/test-data_t-empty_is_empty-framework
merge into: gh-Mbed-TLS:main
Conversation 0 Commits 1 Files changed 1 +5 -14
gilles-peskine-arm commented 2025-06-26 11:39:24 -05:00 (Migrated from github.com)

In binary arguments to test functions, don't allocate an extra byte when a binary input is empty. This could hide bugs where the library tries to access one byte in an empty buffer.

Needs preceding PR: 3.6 and crypto to stop using mbedtls_test_zero_alloc() first.

PR checklist

In binary arguments to test functions, don't allocate an extra byte when a binary input is empty. This could hide bugs where the library tries to access one byte in an empty buffer. Needs preceding PR: 3.6 and crypto to stop using `mbedtls_test_zero_alloc()` first. ## PR checklist - [x] **changelog** not required because: test only - [ ] **development PR** TODO (or not required?) - [x] **TF-PSA-Crypto PR** https://github.com/Mbed-TLS/TF-PSA-Crypto/pull/338 - [x] **framework PR** here - [x] **3.6 PR** https://github.com/Mbed-TLS/mbedtls/pull/10257 - **tests** provided
This pull request is broken due to missing fork information.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin 'gilles-peskine-arm/test-data_t-empty_is_empty-framework:gilles-peskine-arm/test-data_t-empty_is_empty-framework'
git switch 'gilles-peskine-arm/test-data_t-empty_is_empty-framework'

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch 'main'
git merge --no-ff 'gilles-peskine-arm/test-data_t-empty_is_empty-framework'
git switch 'gilles-peskine-arm/test-data_t-empty_is_empty-framework'
git rebase 'main'
git switch 'main'
git merge --ff-only 'gilles-peskine-arm/test-data_t-empty_is_empty-framework'
git switch 'gilles-peskine-arm/test-data_t-empty_is_empty-framework'
git rebase 'main'
git switch 'main'
git merge --no-ff 'gilles-peskine-arm/test-data_t-empty_is_empty-framework'
git switch 'main'
git merge --squash 'gilles-peskine-arm/test-data_t-empty_is_empty-framework'
git switch 'main'
git merge --ff-only 'gilles-peskine-arm/test-data_t-empty_is_empty-framework'
git switch 'main'
git merge 'gilles-peskine-arm/test-data_t-empty_is_empty-framework'
git push origin 'main'
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
approved
Design and code approved - may be waiting for CI or backports

  
bug
Something isn't working

  
dependencies
Pull requests that update a dependency file

  
DO-NOT-MERGE

   
enhancement
New feature or request

  
good-first-issue
Good for newcomers

  
help-wanted
This issue is not being actively worked on, but PRs welcome.

  
historical-reviewed
Reviewed & agreed to keep legacy PR/issue

  
historical-reviewing
Currently reviewing (for legacy PR/issues)

  
needs-adoption
stalled PR that someone should pick up and complete

  
needs-ci
Needs to pass CI tests

  
needs-design-approval

   
needs-info
An issue or PR which needs further info from the reporter / author

  
needs-preceding-pr
Requires another PR to be merged first

  
needs-review
Every commit must be reviewed by at least two team members.

  
needs-reviewer
This PR needs someone to pick it up for review

  
needs-work

   
priority-high
High priority - will be reviewed soon

  
priority-low
Low priority - this may not receive review soon

  
priority-medium
Medium priority - this can be reviewed as time permits

  
priority-scheduled
This PR is big - it will require time to be scheduled for review

  
priority-very-high
Highest priority - prioritise this over other review work

  
single-reviewer
This PR qualifies for having only one reviewer

  
size-l
Estimated task size: large (2w+)

  
size-m
Estimated task size: medium (~1w)

  
size-s
Estimated task size: small (~2d)

  
size-xs
Estimated task size: extra small (a few hours at most)

No labels
approved
bug
dependencies
DO-NOT-MERGE
enhancement
good-first-issue
help-wanted
historical-reviewed
historical-reviewing
needs-adoption
needs-ci
needs-design-approval
needs-info
needs-preceding-pr
needs-review
needs-reviewer
needs-work
priority-high
priority-low
priority-medium
priority-scheduled
priority-very-high
single-reviewer
size-l
size-m
size-s
size-xs
Milestone
Clear milestone
No items
No milestone
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
gh-Mbed-TLS/mbedtls-framework!177
No description provided.