gh-Mbed-TLS/mbedtls-framework
Watch
1
0
Fork
You've already forked mbedtls-framework
 0
Code Issues 39 Pull requests 42 Releases Activity

all.sh: consistently generate files before checks, and not before builds #189

Open
gilles-peskine-arm wants to merge 4 commits from gilles-peskine-arm/all.sh-generate-only-before-checks-framework into main
pull from: gilles-peskine-arm/all.sh-generate-only-before-checks-framework
merge into: gh-Mbed-TLS:main
Conversation 0 Commits 4 Files changed 3 +74 -22
gilles-peskine-arm commented 2025-07-18 11:10:04 -05:00 (Migrated from github.com)

Make the behavior of all.sh with respect to generated files at the beginning of a component:

  • consistent across repositories;
  • independent of the initial content of the working directory;
  • dependent on the component: present for check_xxx (where their absence can lead to a failure or silent loss of test coverage), and absent for builds and tests (where we expect the build scripts to generate them as needed).

Fix https://github.com/Mbed-TLS/mbedtls-framework/issues/188

No change needed in consuming branches (to be confirmed by the CI), but there are a couple of things to clean up in TF-PSA-Crypto.

PR checklist

Please add the numbers (or links) of the associated pull requests for consuming branches. You can omit branches where this pull request is not needed.

  • TF-PSA-Crypto PR
  • development PR provided # | not required because:
  • 3.6 PR provided # | not required because:
Make the behavior of `all.sh` with respect to generated files at the beginning of a component: * consistent across repositories; * independent of the initial content of the working directory; * dependent on the component: present for `check_xxx` (where their absence can lead to a failure or silent loss of test coverage), and absent for builds and tests (where we expect the build scripts to generate them as needed). Fix https://github.com/Mbed-TLS/mbedtls-framework/issues/188 No change needed in consuming branches (to be confirmed by the CI), but there are a couple of things to clean up in TF-PSA-Crypto. ## PR checklist Please add the numbers (or links) of the associated pull requests for consuming branches. You can omit branches where this pull request is not needed. - [x] **TF-PSA-Crypto PR** - [x] **development PR** provided # | not required because: - [x] **3.6 PR** provided # | not required because:
This pull request has changes conflicting with the target branch.
  • scripts/all-core.sh
  • scripts/make_generated_files.py
View command line instructions

Manual merge helper

Use this merge commit message when completing the merge manually.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin 'gilles-peskine-arm/all.sh-generate-only-before-checks-framework:gilles-peskine-arm/all.sh-generate-only-before-checks-framework'
git switch 'gilles-peskine-arm/all.sh-generate-only-before-checks-framework'

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch 'main'
git merge --no-ff 'gilles-peskine-arm/all.sh-generate-only-before-checks-framework'
git switch 'gilles-peskine-arm/all.sh-generate-only-before-checks-framework'
git rebase 'main'
git switch 'main'
git merge --ff-only 'gilles-peskine-arm/all.sh-generate-only-before-checks-framework'
git switch 'gilles-peskine-arm/all.sh-generate-only-before-checks-framework'
git rebase 'main'
git switch 'main'
git merge --no-ff 'gilles-peskine-arm/all.sh-generate-only-before-checks-framework'
git switch 'main'
git merge --squash 'gilles-peskine-arm/all.sh-generate-only-before-checks-framework'
git switch 'main'
git merge --ff-only 'gilles-peskine-arm/all.sh-generate-only-before-checks-framework'
git switch 'main'
git merge 'gilles-peskine-arm/all.sh-generate-only-before-checks-framework'
git push origin 'main'
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
approved
Design and code approved - may be waiting for CI or backports

  
bug
Something isn't working

  
dependencies
Pull requests that update a dependency file

  
DO-NOT-MERGE

   
enhancement
New feature or request

  
good-first-issue
Good for newcomers

  
help-wanted
This issue is not being actively worked on, but PRs welcome.

  
historical-reviewed
Reviewed & agreed to keep legacy PR/issue

  
historical-reviewing
Currently reviewing (for legacy PR/issues)

  
needs-adoption
stalled PR that someone should pick up and complete

  
needs-ci
Needs to pass CI tests

  
needs-design-approval

   
needs-info
An issue or PR which needs further info from the reporter / author

  
needs-preceding-pr
Requires another PR to be merged first

  
needs-review
Every commit must be reviewed by at least two team members.

  
needs-reviewer
This PR needs someone to pick it up for review

  
needs-work

   
priority-high
High priority - will be reviewed soon

  
priority-low
Low priority - this may not receive review soon

  
priority-medium
Medium priority - this can be reviewed as time permits

  
priority-scheduled
This PR is big - it will require time to be scheduled for review

  
priority-very-high
Highest priority - prioritise this over other review work

  
single-reviewer
This PR qualifies for having only one reviewer

  
size-l
Estimated task size: large (2w+)

  
size-m
Estimated task size: medium (~1w)

  
size-s
Estimated task size: small (~2d)

  
size-xs
Estimated task size: extra small (a few hours at most)

No labels
approved
bug
dependencies
DO-NOT-MERGE
enhancement
good-first-issue
help-wanted
historical-reviewed
historical-reviewing
needs-adoption
needs-ci
needs-design-approval
needs-info
needs-preceding-pr
needs-review
needs-reviewer
needs-work
priority-high
priority-low
priority-medium
priority-scheduled
priority-very-high
single-reviewer
size-l
size-m
size-s
size-xs
Milestone
Clear milestone
No items
No milestone
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
gh-Mbed-TLS/mbedtls-framework!189
No description provided.