Fix generate_config_checks.py not actually generating the files #211

2025-09-16T05:45:31-05:00

gilles-peskine-arm commented

2025-09-16 05:45:31 -05:00

(Migrated from github.com)

Fix silly mistake in #196 that clogs up the chain of consumers.

PR checklist

Please add the numbers (or links) of the associated pull requests for consuming branches. You can omit branches where this pull request is not needed.

TF-PSA-Crypto PR provided https://github.com/Mbed-TLS/TF-PSA-Crypto/pull/404
development PR provided https://github.com/Mbed-TLS/mbedtls/pull/10340
3.6 PR not required because: new featre

Fix silly mistake in #196 that clogs up the chain of consumers. ## PR checklist Please add the numbers (or links) of the associated pull requests for consuming branches. You can omit branches where this pull request is not needed. - [x] **TF-PSA-Crypto PR** provided https://github.com/Mbed-TLS/TF-PSA-Crypto/pull/404 - [x] **development PR** provided https://github.com/Mbed-TLS/mbedtls/pull/10340 - [x] **3.6 PR** not required because: new featre

gilles-peskine-arm (Migrated from github.com) reviewed

2025-09-16 05:48:52 -05:00

scripts/mbedtls_framework/config_checks_generator.py

					
				@ -224,1 +221,4 @@

				    output_files = list(generate_header_files(branch_data,

				                                              options.output_directory,

				                                              list_only=list_only))

				    if options.list_for_cmake:

The fact that we all missed this at first shows that this is not a good way to write the code. But right now I'd rather unblock the chain of PR ASAP.

mpg (Migrated from github.com) approved these changes

2025-09-16 05:50:37 -05:00

mpg (Migrated from github.com) left a comment

LGTM.

I feel silly for missing this, because I was about to say the function might as well return a list (or tuple) directly, then I thought it's probably a matter of taste, let's not delay the PR over this... but completely missed the practical impact here :(

LGTM. I feel silly for missing this, because I was about to say the function might as well return a list (or tuple) directly, then I thought it's probably a matter of taste, let's not delay the PR over this... but completely missed the practical impact here :(

minosgalanakis (Migrated from github.com) approved these changes

2025-09-16 06:14:29 -05:00

minosgalanakis (Migrated from github.com) left a comment

LGTM

Sign in to join this conversation.

No reviewers

mpg

minosgalanakis

No milestone

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

gh-Mbed-TLS/mbedtls-framework!211

Rows
Columns