gh-Mbed-TLS/mbedtls-framework
Watch
1
0
Fork
You've already forked mbedtls-framework
 0
Code Issues 39 Pull requests 42 Releases Activity

Document how generate_config_checks.py accesses current information #262

Merged
gilles-peskine-arm merged 2 commits from config-checks-generator-current-spec into main 2026-09-16 07:24:47 -05:00
Conversation 5 Commits 2 Files changed 1 +25
gilles-peskine-arm commented 2026-01-05 13:49:12 -06:00 (Migrated from github.com)

Update the specification of generated config checks in accordance with the resolution of https://github.com/Mbed-TLS/mbedtls-framework/issues/249.

Companion to https://github.com/Mbed-TLS/mbedtls-framework/pull/260 which has the implementation.

PR checklist

Update the specification of generated config checks in accordance with the resolution of https://github.com/Mbed-TLS/mbedtls-framework/issues/249. Companion to https://github.com/Mbed-TLS/mbedtls-framework/pull/260 which has the implementation. ## PR checklist - [x] **TF-PSA-Crypto PR** provided https://github.com/Mbed-TLS/TF-PSA-Crypto/pull/619 - [x] **development PR** provided https://github.com/Mbed-TLS/mbedtls/pull/10548 - [x] **3.6 PR** provided # | not required because: feature added in 1.0/4.0
mpg (Migrated from github.com) reviewed 2026-01-06 04:21:46 -06:00
mpg (Migrated from github.com) left a comment
No description provided.
LGTM, thanks!
bjwtaylor (Migrated from github.com) reviewed 2026-09-15 08:10:06 -05:00
docs/architecture/config-check-framework.md
@ -134,6 +134,31 @@ The generation happens before build time as part of `make generated_files` or si
bjwtaylor (Migrated from github.com) commented 2026-09-15 08:09:50 -05:00

I believe tests/scripts/check_option_lists.py no longer exists and is now tests/scripts/check_committed_generated_files.py?

I believe tests/scripts/check_option_lists.py no longer exists and is now tests/scripts/check_committed_generated_files.py?
gilles-peskine-arm commented 2026-09-15 09:12:21 -05:00 (Migrated from github.com)

I've rebased on top of main to have a chance of passing the CI. I'll update the content in a new commit.

I've rebased on top of `main` to have a chance of passing the CI. I'll update the content in a new commit.
mpg (Migrated from github.com) approved these changes 2026-09-16 02:28:28 -05:00
mpg (Migrated from github.com) left a comment

LGTM, thanks!

LGTM, thanks!
bjwtaylor (Migrated from github.com) approved these changes 2026-09-16 07:13:34 -05:00
Sign in to join this conversation.
Reviewers
No reviewers
mpg
bjwtaylor
Labels
Clear labels   
approved
Design and code approved - may be waiting for CI or backports

  
bug
Something isn't working

  
dependencies
Pull requests that update a dependency file

  
DO-NOT-MERGE

   
enhancement
New feature or request

  
good-first-issue
Good for newcomers

  
help-wanted
This issue is not being actively worked on, but PRs welcome.

  
historical-reviewed
Reviewed & agreed to keep legacy PR/issue

  
historical-reviewing
Currently reviewing (for legacy PR/issues)

  
needs-adoption
stalled PR that someone should pick up and complete

  
needs-ci
Needs to pass CI tests

  
needs-design-approval

   
needs-info
An issue or PR which needs further info from the reporter / author

  
needs-preceding-pr
Requires another PR to be merged first

  
needs-review
Every commit must be reviewed by at least two team members.

  
needs-reviewer
This PR needs someone to pick it up for review

  
needs-work

   
priority-high
High priority - will be reviewed soon

  
priority-low
Low priority - this may not receive review soon

  
priority-medium
Medium priority - this can be reviewed as time permits

  
priority-scheduled
This PR is big - it will require time to be scheduled for review

  
priority-very-high
Highest priority - prioritise this over other review work

  
single-reviewer
This PR qualifies for having only one reviewer

  
size-l
Estimated task size: large (2w+)

  
size-m
Estimated task size: medium (~1w)

  
size-s
Estimated task size: small (~2d)

  
size-xs
Estimated task size: extra small (a few hours at most)

No labels
approved
bug
dependencies
DO-NOT-MERGE
enhancement
good-first-issue
help-wanted
historical-reviewed
historical-reviewing
needs-adoption
needs-ci
needs-design-approval
needs-info
needs-preceding-pr
needs-review
needs-reviewer
needs-work
priority-high
priority-low
priority-medium
priority-scheduled
priority-very-high
single-reviewer
size-l
size-m
size-s
size-xs
Milestone
Clear milestone
No items
No milestone
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
gh-Mbed-TLS/mbedtls-framework!262
No description provided.