gh-Mbed-TLS/mbedtls-framework
Watch
1
0
Fork
You've already forked mbedtls-framework
 0
Code Issues 39 Pull requests 42 Releases Activity

Add explicit parameter variants to ec_*_pub data files #285

Open
Marandil wants to merge 2 commits from Marandil/fix/mbedtls-4314-test-data into main
pull from: Marandil/fix/mbedtls-4314-test-data
merge into: gh-Mbed-TLS:main
Conversation 4 Commits 2 Files changed 13 +136
Marandil commented 2026-03-04 09:33:56 -06:00 (Migrated from github.com)

Description

Add explicit parameter variants to ec_*_pub data files. These are required for the new tests included in
https://github.com/Mbed-TLS/TF-PSA-Crypto/pull/705 and https://github.com/Mbed-TLS/mbedtls/pull/10630

The variants have been generated with the following command:

openssl ec -pubin -param_enc explicit -pubout -in ec_XYZ_pub.der -out ec_XYZ_pub.expl.der -outform der

(with the proper choice of XYZ or der/pem)

PR checklist

Please add the numbers (or links) of the associated pull requests for consuming branches. You can omit branches where this pull request is not needed.

Notes for the submitter

Please refer to the contributing guidelines, especially the
checklist for PR contributors.

Help make review efficient:

  • Multiple simple commits
    • please structure your PR into a series of small commits, each of which does one thing
  • Avoid force-push
    • please do not force-push to update your PR - just add new commit(s)
  • See our Guidelines for Contributors for more details about the review process.
## Description Add explicit parameter variants to ec_*_pub data files. These are required for the new tests included in https://github.com/Mbed-TLS/TF-PSA-Crypto/pull/705 and https://github.com/Mbed-TLS/mbedtls/pull/10630 The variants have been generated with the following command: ```bash openssl ec -pubin -param_enc explicit -pubout -in ec_XYZ_pub.der -out ec_XYZ_pub.expl.der -outform der ``` (with the proper choice of XYZ or `der`/`pem`) ## PR checklist Please add the numbers (or links) of the associated pull requests for consuming branches. You can omit branches where this pull request is not needed. - [ ] **TF-PSA-Crypto PR** provided https://github.com/Mbed-TLS/TF-PSA-Crypto/pull/705 - [ ] **development PR** not required because: no changes to development - [ ] **3.6 PR** provided https://github.com/Mbed-TLS/mbedtls/pull/10630 ## Notes for the submitter Please refer to the [contributing guidelines](https://github.com/Mbed-TLS/mbedtls/blob/development/CONTRIBUTING.md), especially the checklist for PR contributors. Help make review efficient: * Multiple simple commits - please structure your PR into a series of small commits, each of which does one thing * Avoid force-push - please do not force-push to update your PR - just add new commit(s) * See our [Guidelines for Contributors](https://mbed-tls.readthedocs.io/en/latest/reviews/review-for-contributors/) for more details about the review process.
gilles-peskine-arm (Migrated from github.com) reviewed 2026-03-04 10:54:00 -06:00
data_files/ec_224_pub.expl.pem
@ -0,0 +1,9 @@
-----BEGIN PUBLIC KEY-----
gilles-peskine-arm (Migrated from github.com) commented 2026-03-04 10:54:00 -06:00

Please add the commands to generate the files in data_files/Makefile. We do want the keys to be committed (so that you don't have to have the right version of openssl to run the tests), but it helps to keep track of exactly how the files were generated.

Please add the commands to generate the files in `data_files/Makefile`. We do want the keys to be committed (so that you don't have to have the right version of openssl to run the tests), but it helps to keep track of exactly how the files were generated.
gilles-peskine-arm commented 2026-03-04 10:54:40 -06:00 (Migrated from github.com)

As in the crypto PR, please ensure that all commit messages have a signoff line, so that the DCO check passes.

As in the crypto PR, please ensure that all commit messages have a signoff line, so that the DCO check passes.
Marandil (Migrated from github.com) reviewed 2026-03-04 12:16:41 -06:00
data_files/ec_224_pub.expl.pem
@ -0,0 +1,9 @@
-----BEGIN PUBLIC KEY-----
Marandil (Migrated from github.com) commented 2026-03-04 12:16:40 -06:00

Added in 5248905, I also removed and re-ran make to ensure I got the same results.

Added in [5248905](https://github.com/Mbed-TLS/mbedtls-framework/pull/285/commits/5248905002408fb4e89af9a35a9e2c14431ee305), I also removed and re-ran make to ensure I got the same results.
valeriosetti (Migrated from github.com) approved these changes 2026-05-05 02:56:07 -05:00
valeriosetti (Migrated from github.com) left a comment

I just kicked the CI on this. If it passes then I'm OK with the PR ;)

I just kicked the CI on this. If it passes then I'm OK with the PR ;)
This pull request is broken due to missing fork information.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin 'Marandil/fix/mbedtls-4314-test-data:Marandil/fix/mbedtls-4314-test-data'
git switch 'Marandil/fix/mbedtls-4314-test-data'

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch 'main'
git merge --no-ff 'Marandil/fix/mbedtls-4314-test-data'
git switch 'Marandil/fix/mbedtls-4314-test-data'
git rebase 'main'
git switch 'main'
git merge --ff-only 'Marandil/fix/mbedtls-4314-test-data'
git switch 'Marandil/fix/mbedtls-4314-test-data'
git rebase 'main'
git switch 'main'
git merge --no-ff 'Marandil/fix/mbedtls-4314-test-data'
git switch 'main'
git merge --squash 'Marandil/fix/mbedtls-4314-test-data'
git switch 'main'
git merge --ff-only 'Marandil/fix/mbedtls-4314-test-data'
git switch 'main'
git merge 'Marandil/fix/mbedtls-4314-test-data'
git push origin 'main'
Sign in to join this conversation.
Reviewers
No reviewers
valeriosetti
Labels
Clear labels   
approved
Design and code approved - may be waiting for CI or backports

  
bug
Something isn't working

  
dependencies
Pull requests that update a dependency file

  
DO-NOT-MERGE

   
enhancement
New feature or request

  
good-first-issue
Good for newcomers

  
help-wanted
This issue is not being actively worked on, but PRs welcome.

  
historical-reviewed
Reviewed & agreed to keep legacy PR/issue

  
historical-reviewing
Currently reviewing (for legacy PR/issues)

  
needs-adoption
stalled PR that someone should pick up and complete

  
needs-ci
Needs to pass CI tests

  
needs-design-approval

   
needs-info
An issue or PR which needs further info from the reporter / author

  
needs-preceding-pr
Requires another PR to be merged first

  
needs-review
Every commit must be reviewed by at least two team members.

  
needs-reviewer
This PR needs someone to pick it up for review

  
needs-work

   
priority-high
High priority - will be reviewed soon

  
priority-low
Low priority - this may not receive review soon

  
priority-medium
Medium priority - this can be reviewed as time permits

  
priority-scheduled
This PR is big - it will require time to be scheduled for review

  
priority-very-high
Highest priority - prioritise this over other review work

  
single-reviewer
This PR qualifies for having only one reviewer

  
size-l
Estimated task size: large (2w+)

  
size-m
Estimated task size: medium (~1w)

  
size-s
Estimated task size: small (~2d)

  
size-xs
Estimated task size: extra small (a few hours at most)

No labels
approved
bug
dependencies
DO-NOT-MERGE
enhancement
good-first-issue
help-wanted
historical-reviewed
historical-reviewing
needs-adoption
needs-ci
needs-design-approval
needs-info
needs-preceding-pr
needs-review
needs-reviewer
needs-work
priority-high
priority-low
priority-medium
priority-scheduled
priority-very-high
single-reviewer
size-l
size-m
size-s
size-xs
Milestone
Clear milestone
No items
No milestone
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
gh-Mbed-TLS/mbedtls-framework!285
No description provided.