gh-Mbed-TLS/mbedtls-framework
Watch
1
0
Fork
You've already forked mbedtls-framework
 0
Code Issues 39 Pull requests 42 Releases Activity

Test data for failure caused by empty digest algorithm #302

Open
bjwtaylor wants to merge 4 commits from bjwtaylor/empty-digest-failure into main
pull from: bjwtaylor/empty-digest-failure
merge into: gh-Mbed-TLS:main
Conversation 4 Commits 4 Files changed 3 +27
bjwtaylor commented 2026-05-01 09:23:48 -05:00 (Migrated from github.com)

Description

Test data for failure caused by empty digest algorithm. contributes https://github.com/Mbed-TLS/mbedtls/issues/10480.

Parameterised build https://ci.trustedfirmware.org/view/Mbed-TLS/job/mbed-tls-restricted-pr-test-parametrized/176/

This PR is part of a two part set which must be merged in the following order:

  1. https://github.com/Mbed-TLS/mbedtls-framework/pull/302
  2. https://github.com/Mbed-TLS/mbedtls/pull/10746

PR checklist

  • TF-PSA-Crypto development PR not required because: No changes
  • TF-PSA-Crypto 1.1 PR not required because: No changes
  • mbedtls development PR provided https://github.com/Mbed-TLS/mbedtls/pull/10746
  • mbedtls 4.1 PR provided # | not required because: TBC
  • mbedtls 3.6 PR provided # | not required because: TBC
## Description Test data for failure caused by empty digest algorithm. contributes https://github.com/Mbed-TLS/mbedtls/issues/10480. Parameterised build https://ci.trustedfirmware.org/view/Mbed-TLS/job/mbed-tls-restricted-pr-test-parametrized/176/ This PR is part of a two part set which must be merged in the following order: 1. https://github.com/Mbed-TLS/mbedtls-framework/pull/302 2. https://github.com/Mbed-TLS/mbedtls/pull/10746 ## PR checklist - [ ] **TF-PSA-Crypto development PR** not required because: No changes - [ ] **TF-PSA-Crypto 1.1 PR** not required because: No changes - [ ] **mbedtls development PR** provided https://github.com/Mbed-TLS/mbedtls/pull/10746 - [ ] **mbedtls 4.1 PR** provided # | not required because: TBC - [ ] **mbedtls 3.6 PR** provided # | not required because: TBC
valeriosetti (Migrated from github.com) requested changes 2026-07-06 05:00:45 -05:00
valeriosetti (Migrated from github.com) left a comment

Usually each data file in this folder has an associated make rule in the Makefile. This helps in case in the future the file has to be re-generated for some reason.
I don't know how you get these files, but do you think it should be possible to do this?

Usually each data file in this folder has an associated make rule in the Makefile. This helps in case in the future the file has to be re-generated for some reason. I don't know how you get these files, but do you think it should be possible to do this?
valeriosetti (Migrated from github.com) requested changes 2026-07-06 05:04:16 -05:00
valeriosetti (Migrated from github.com) left a comment

Given the description provided in https://github.com/Mbed-TLS/mbedtls/issues/10480 should we want to have something similar to pkcs7_empty_digest.der but with some CRT in it?
Probably this doesn't change anything compared to pkcs7_empty_digest.der, but it would be something close to some real use case. Wdyt?
Sorry perhaps that's already covered from pkcs7_data_cert_signed_sha256_empty_digest.der 🤔

~Given the description provided in https://github.com/Mbed-TLS/mbedtls/issues/10480 should we want to have something similar to `pkcs7_empty_digest.der` but with some CRT in it? Probably this doesn't change anything compared to `pkcs7_empty_digest.der`, but it would be something close to some real use case. Wdyt?~ Sorry perhaps that's already covered from `pkcs7_data_cert_signed_sha256_empty_digest.der` :thinking:
bjwtaylor commented 2026-07-06 05:36:41 -05:00 (Migrated from github.com)

@valeriosetti, I've added a section to the makefile.

@valeriosetti, I've added a section to the makefile.
valeriosetti (Migrated from github.com) approved these changes 2026-07-06 07:35:18 -05:00
This pull request is broken due to missing fork information.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin 'bjwtaylor/empty-digest-failure:bjwtaylor/empty-digest-failure'
git switch 'bjwtaylor/empty-digest-failure'

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch 'main'
git merge --no-ff 'bjwtaylor/empty-digest-failure'
git switch 'bjwtaylor/empty-digest-failure'
git rebase 'main'
git switch 'main'
git merge --ff-only 'bjwtaylor/empty-digest-failure'
git switch 'bjwtaylor/empty-digest-failure'
git rebase 'main'
git switch 'main'
git merge --no-ff 'bjwtaylor/empty-digest-failure'
git switch 'main'
git merge --squash 'bjwtaylor/empty-digest-failure'
git switch 'main'
git merge --ff-only 'bjwtaylor/empty-digest-failure'
git switch 'main'
git merge 'bjwtaylor/empty-digest-failure'
git push origin 'main'
Sign in to join this conversation.
Reviewers
No reviewers
valeriosetti
Labels
Clear labels   
approved
Design and code approved - may be waiting for CI or backports

  
bug
Something isn't working

  
dependencies
Pull requests that update a dependency file

  
DO-NOT-MERGE

   
enhancement
New feature or request

  
good-first-issue
Good for newcomers

  
help-wanted
This issue is not being actively worked on, but PRs welcome.

  
historical-reviewed
Reviewed & agreed to keep legacy PR/issue

  
historical-reviewing
Currently reviewing (for legacy PR/issues)

  
needs-adoption
stalled PR that someone should pick up and complete

  
needs-ci
Needs to pass CI tests

  
needs-design-approval

   
needs-info
An issue or PR which needs further info from the reporter / author

  
needs-preceding-pr
Requires another PR to be merged first

  
needs-review
Every commit must be reviewed by at least two team members.

  
needs-reviewer
This PR needs someone to pick it up for review

  
needs-work

   
priority-high
High priority - will be reviewed soon

  
priority-low
Low priority - this may not receive review soon

  
priority-medium
Medium priority - this can be reviewed as time permits

  
priority-scheduled
This PR is big - it will require time to be scheduled for review

  
priority-very-high
Highest priority - prioritise this over other review work

  
single-reviewer
This PR qualifies for having only one reviewer

  
size-l
Estimated task size: large (2w+)

  
size-m
Estimated task size: medium (~1w)

  
size-s
Estimated task size: small (~2d)

  
size-xs
Estimated task size: extra small (a few hours at most)

No labels
approved
bug
dependencies
DO-NOT-MERGE
enhancement
good-first-issue
help-wanted
historical-reviewed
historical-reviewing
needs-adoption
needs-ci
needs-design-approval
needs-info
needs-preceding-pr
needs-review
needs-reviewer
needs-work
priority-high
priority-low
priority-medium
priority-scheduled
priority-very-high
single-reviewer
size-l
size-m
size-s
size-xs
Milestone
Clear milestone
No items
No milestone
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
gh-Mbed-TLS/mbedtls-framework!302
No description provided.