gh-Mbed-TLS/mbedtls-framework
Watch
1
0
Fork
You've already forked mbedtls-framework
 0
Code Issues 39 Pull requests 42 Releases Activity

Remove deprecated use of count as positional arg #62

Open
paul-elliott-arm wants to merge 1 commit from paul-elliott-arm/remove_re_sub_count_positional_arg into main
pull from: paul-elliott-arm/remove_re_sub_count_positional_arg
merge into: gh-Mbed-TLS:main
Conversation 3 Commits 1 Files changed 1 +1 -1
paul-elliott-arm commented 2024-10-25 08:50:50 -05:00 (Migrated from github.com)

No intended change in functionality. Just removing the deprecated warning I am getting every time I generate test code.

Python 13 requires count to be passed as a kwarg rather than a positional arg because of potential confusion with flags, see https://github.com/python/cpython/issues/56166

No intended change in functionality. Just removing the deprecated warning I am getting every time I generate test code. Python 13 requires count to be passed as a kwarg rather than a positional arg because of potential confusion with flags, see https://github.com/python/cpython/issues/56166
gilles-peskine-arm (Migrated from github.com) approved these changes 2024-10-25 09:58:28 -05:00
gilles-peskine-arm (Migrated from github.com) left a comment

LGTM

LGTM
gilles-peskine-arm (Migrated from github.com) requested changes 2024-10-25 10:00:34 -05:00
gilles-peskine-arm (Migrated from github.com) left a comment

breaks pylint

breaks pylint
scripts/generate_test_code.py
@ -762,7 +762,7 @@ def escaped_split(inp_str, split_char):
raise ValueError('Expected split character. Found string!')
gilles-peskine-arm (Migrated from github.com) commented 2024-10-25 10:00:28 -05:00 
                 count=len(inp_str)).split('\n')

otherwise pylint will complain

```suggestion count=len(inp_str)).split('\n') ``` otherwise pylint will complain
gilles-peskine-arm (Migrated from github.com) reviewed 2024-10-25 10:02:00 -05:00
scripts/generate_test_code.py
@ -762,7 +762,7 @@ def escaped_split(inp_str, split_char):
raise ValueError('Expected split character. Found string!')
gilles-peskine-arm (Migrated from github.com) commented 2024-10-25 10:02:00 -05:00

Until we have a CI in the framework repository, please at least run directly relevant tests. Here, at least check-python-files.sh (in a CI-like venv), and make tests.

Until we have a CI in the framework repository, please at least run directly relevant tests. Here, at least `check-python-files.sh` (in a CI-like venv), and `make tests`.
This pull request is broken due to missing fork information.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin 'paul-elliott-arm/remove_re_sub_count_positional_arg:paul-elliott-arm/remove_re_sub_count_positional_arg'
git switch 'paul-elliott-arm/remove_re_sub_count_positional_arg'

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch 'main'
git merge --no-ff 'paul-elliott-arm/remove_re_sub_count_positional_arg'
git switch 'paul-elliott-arm/remove_re_sub_count_positional_arg'
git rebase 'main'
git switch 'main'
git merge --ff-only 'paul-elliott-arm/remove_re_sub_count_positional_arg'
git switch 'paul-elliott-arm/remove_re_sub_count_positional_arg'
git rebase 'main'
git switch 'main'
git merge --no-ff 'paul-elliott-arm/remove_re_sub_count_positional_arg'
git switch 'main'
git merge --squash 'paul-elliott-arm/remove_re_sub_count_positional_arg'
git switch 'main'
git merge --ff-only 'paul-elliott-arm/remove_re_sub_count_positional_arg'
git switch 'main'
git merge 'paul-elliott-arm/remove_re_sub_count_positional_arg'
git push origin 'main'
Sign in to join this conversation.
Reviewers
No reviewers
gilles-peskine-arm
Labels
Clear labels   
approved
Design and code approved - may be waiting for CI or backports

  
bug
Something isn't working

  
dependencies
Pull requests that update a dependency file

  
DO-NOT-MERGE

   
enhancement
New feature or request

  
good-first-issue
Good for newcomers

  
help-wanted
This issue is not being actively worked on, but PRs welcome.

  
historical-reviewed
Reviewed & agreed to keep legacy PR/issue

  
historical-reviewing
Currently reviewing (for legacy PR/issues)

  
needs-adoption
stalled PR that someone should pick up and complete

  
needs-ci
Needs to pass CI tests

  
needs-design-approval

   
needs-info
An issue or PR which needs further info from the reporter / author

  
needs-preceding-pr
Requires another PR to be merged first

  
needs-review
Every commit must be reviewed by at least two team members.

  
needs-reviewer
This PR needs someone to pick it up for review

  
needs-work

   
priority-high
High priority - will be reviewed soon

  
priority-low
Low priority - this may not receive review soon

  
priority-medium
Medium priority - this can be reviewed as time permits

  
priority-scheduled
This PR is big - it will require time to be scheduled for review

  
priority-very-high
Highest priority - prioritise this over other review work

  
single-reviewer
This PR qualifies for having only one reviewer

  
size-l
Estimated task size: large (2w+)

  
size-m
Estimated task size: medium (~1w)

  
size-s
Estimated task size: small (~2d)

  
size-xs
Estimated task size: extra small (a few hours at most)

No labels
approved
bug
dependencies
DO-NOT-MERGE
enhancement
good-first-issue
help-wanted
historical-reviewed
historical-reviewing
needs-adoption
needs-ci
needs-design-approval
needs-info
needs-preceding-pr
needs-review
needs-reviewer
needs-work
priority-high
priority-low
priority-medium
priority-scheduled
priority-very-high
single-reviewer
size-l
size-m
size-s
size-xs
Milestone
Clear milestone
No items
No milestone
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
gh-Mbed-TLS/mbedtls-framework!62
No description provided.