gh-Mbed-TLS/mbedtls-framework
Watch
1
0
Fork
You've already forked mbedtls-framework
 0
Code Issues 39 Pull requests 42 Releases Activity

Port psa_exercise_key changes added mid-framework-move #78

Merged
davidhorstmann-arm merged 2 commits from dev/davidhorstmann-arm/port-psa-exercise-key-changes into main 2024-11-20 03:55:30 -06:00
Conversation 6 Commits 2 Files changed 2 +58 -1
davidhorstmann-arm commented 2024-11-18 10:36:32 -06:00 (Migrated from github.com)

These changes to psa_exercise_key were added while the files were being moved to the framework. Port them to the framework now.

These changes to `psa_exercise_key` were added while the files were being moved to the framework. Port them to the framework now.
eleuzi01 (Migrated from github.com) reviewed 2024-11-18 10:53:36 -06:00
eleuzi01 (Migrated from github.com) left a comment
No description provided.
LGTM, all the relevant changes from [#9602](https://github.com/Mbed-TLS/mbedtls/pull/9602) seem to be ported
mpg (Migrated from github.com) approved these changes 2024-11-19 02:27:57 -06:00
mpg (Migrated from github.com) left a comment

LGTM, I checked that all the changes that were made in development after the file was moved here are present.

LGTM, I checked that all the changes that were made in development after the file was moved here are present.
mpg (Migrated from github.com) requested changes 2024-11-19 03:24:10 -06:00
tests/src/psa_exercise_key.c
@ -737,0 +766,4 @@
goto exit;
}
exported_size = PSA_EXPORT_KEY_OUTPUT_SIZE(psa_get_key_type(&export_attributes),
mpg (Migrated from github.com) commented 2024-11-19 03:24:05 -06:00

Actually this won't work for 3.6, so we'll need some guards, see https://github.com/Mbed-TLS/mbedtls/pull/9766#issuecomment-2485052543

Actually this won't work for 3.6, so we'll need some guards, see https://github.com/Mbed-TLS/mbedtls/pull/9766#issuecomment-2485052543
mpg (Migrated from github.com) approved these changes 2024-11-20 02:36:32 -06:00
mpg (Migrated from github.com) left a comment

LGTM, thanks!

LGTM, thanks!
mpg commented 2024-11-20 02:37:26 -06:00 (Migrated from github.com)

CI is green on https://github.com/Mbed-TLS/mbedtls/pull/9756 and https://github.com/Mbed-TLS/mbedtls/pull/9766 so the result here can be ignored.

CI is green on https://github.com/Mbed-TLS/mbedtls/pull/9756 and https://github.com/Mbed-TLS/mbedtls/pull/9766 so the result here can be ignored.
eleuzi01 (Migrated from github.com) approved these changes 2024-11-20 03:10:29 -06:00
eleuzi01 (Migrated from github.com) left a comment

LGTM

LGTM
Sign in to join this conversation.
Reviewers
No reviewers
mpg
eleuzi01
Labels
Clear labels   
approved
Design and code approved - may be waiting for CI or backports

  
bug
Something isn't working

  
dependencies
Pull requests that update a dependency file

  
DO-NOT-MERGE

   
enhancement
New feature or request

  
good-first-issue
Good for newcomers

  
help-wanted
This issue is not being actively worked on, but PRs welcome.

  
historical-reviewed
Reviewed & agreed to keep legacy PR/issue

  
historical-reviewing
Currently reviewing (for legacy PR/issues)

  
needs-adoption
stalled PR that someone should pick up and complete

  
needs-ci
Needs to pass CI tests

  
needs-design-approval

   
needs-info
An issue or PR which needs further info from the reporter / author

  
needs-preceding-pr
Requires another PR to be merged first

  
needs-review
Every commit must be reviewed by at least two team members.

  
needs-reviewer
This PR needs someone to pick it up for review

  
needs-work

   
priority-high
High priority - will be reviewed soon

  
priority-low
Low priority - this may not receive review soon

  
priority-medium
Medium priority - this can be reviewed as time permits

  
priority-scheduled
This PR is big - it will require time to be scheduled for review

  
priority-very-high
Highest priority - prioritise this over other review work

  
single-reviewer
This PR qualifies for having only one reviewer

  
size-l
Estimated task size: large (2w+)

  
size-m
Estimated task size: medium (~1w)

  
size-s
Estimated task size: small (~2d)

  
size-xs
Estimated task size: extra small (a few hours at most)

No labels
approved
bug
dependencies
DO-NOT-MERGE
enhancement
good-first-issue
help-wanted
historical-reviewed
historical-reviewing
needs-adoption
needs-ci
needs-design-approval
needs-info
needs-preceding-pr
needs-review
needs-reviewer
needs-work
priority-high
priority-low
priority-medium
priority-scheduled
priority-very-high
single-reviewer
size-l
size-m
size-s
size-xs
Milestone
Clear milestone
No items
No milestone
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
gh-Mbed-TLS/mbedtls-framework!78
No description provided.