gh-bitflags/bitflags
Watch
1
0
Fork
You've already forked bitflags
 0
Code Issues 10 Pull requests Releases 53 Activity

Fix the implementation of Formatting traits when other formatting traits were present in scope. #105

Merged
CensoredUsername merged 1 commit from master into master 2017-05-29 11:05:11 -05:00
Conversation 3 Commits 1 Files changed 2 +24 -4
CensoredUsername commented 2017-05-29 09:03:12 -05:00 (Migrated from github.com)

The formatting impls did not explicitly specify which trait was being invoked, which lead to conflicting implementation errors if any other formatting trait was present in scope before the bitflags! invocation (even just a use std::fmt::Display beforehand was enough to cause compilation failures.

The formatting impls did not explicitly specify which trait was being invoked, which lead to conflicting implementation errors if any other formatting trait was present in scope before the bitflags! invocation (even just a `use std::fmt::Display` beforehand was enough to cause compilation failures.
dtolnay (Migrated from github.com) approved these changes 2017-05-29 09:48:01 -05:00
dtolnay (Migrated from github.com) left a comment

Looks good to me. Thank you!

Looks good to me. Thank you!
dtolnay commented 2017-05-29 11:12:38 -05:00 (Migrated from github.com)

I published this in bitflags 0.9.1.

I published this in bitflags 0.9.1.
CensoredUsername commented 2017-05-29 11:29:21 -05:00 (Migrated from github.com)

Thanks for the quick response!

Thanks for the quick response!
Sign in to join this conversation.
Reviewers
No reviewers
dtolnay
Labels
Clear labels   
bug

   
good first issue
No labels
bug
good first issue
Milestone
Clear milestone
No items
No milestone
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
gh-bitflags/bitflags!105
No description provided.