add MyFlags::Abc::iter_equal_names() method #489

2026-06-03T18:05:13-05:00

ssrlive commented

2026-06-03 18:05:13 -05:00

(Migrated from github.com)

No description provided.

KodrAus (Migrated from github.com) reviewed

2026-06-03 18:28:42 -05:00

src/iter.rs

					
				@ -180,3 +180,35 @@ impl<B: Flags> Iterator for IterDefinedNames<B> {

				        None

IterEqualNames?

`IterEqualNames`?

src/lib.rs

We unfortunately can't add this as an inherent method on the generated flags type, because it can conflict with an inherent method already added by the user.

We'll need to add it to the Flags trait instead.

We unfortunately can't add this as an inherent method on the generated flags type, because it can conflict with an inherent method already added by the user. We'll need to add it to the `Flags` trait instead.

ssrlive commented

2026-06-03 20:08:14 -05:00

(Migrated from github.com)

I have changed the code following your suggestions.

KodrAus (Migrated from github.com) reviewed

2026-06-05 16:13:41 -05:00

src/iter.rs

					
				@ -180,3 +180,35 @@ impl<B: Flags> Iterator for IterDefinedNames<B> {

				        None

If possible we should make this pub(crate) to avoid exposing any more surface area than we need to.

If possible we should make this `pub(crate)` to avoid exposing any more surface area than we need to.

ssrlive (Migrated from github.com) reviewed

2026-06-05 17:55:15 -05:00

src/iter.rs

					
				@ -180,3 +180,35 @@ impl<B: Flags> Iterator for IterDefinedNames<B> {

				        None

fixed

KodrAus (Migrated from github.com) approved these changes

2026-06-05 18:53:22 -05:00

KodrAus (Migrated from github.com) left a comment

Thanks @ssrlive! This looks good to me

Sign in to join this conversation.

No reviewers

KodrAus

No labels

bug

good first issue

No milestone

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

gh-bitflags/bitflags!489

				`@ -180,3 +180,35 @@ impl<B: Flags> Iterator for IterDefinedNames<B> {`
				`None`

Rows
Columns