Add u128 feature for complete u128 compatibility #57
No reviewers
Labels
No labels
bug
good first issue
No milestone
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
gh-bitflags/bitflags!57
Loading…
Reference in a new issue
No description provided.
Delete branch "master"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Added a u128 feature with a feature gated bitflags width type for use in the macro. Enables functionality like debug formatting of flags that exceed 64 bits. #56
This seems to only be used in the formatting pieces, and there could we just use
$Tinstead of an explicit size? That way we could defer this decision entirely to downstream crates I think?Implemented as suggested. The change does require absolute paths for custom types and type aliases.
Oh right sorry I forgot about that :(, that's actually a pretty crucial reason for this feature.
In that case I guess we'll have to stick with an unstable feature
I will revert to my original PR. Any comments or suggestions?
Looks like this may still be the requires-absolute-paths version?
Thanks!
#61 reimplements this in a different way that neither requires absolute paths nor a cfg to opt into u128 compatibility.