Add u128 feature for complete u128 compatibility #57

Merged
astocko merged 6 commits from master into master 2017-02-11 23:29:13 -06:00
astocko commented 2017-02-10 20:13:51 -06:00 (Migrated from github.com)

Added a u128 feature with a feature gated bitflags width type for use in the macro. Enables functionality like debug formatting of flags that exceed 64 bits. #56

Added a u128 feature with a feature gated bitflags width type for use in the macro. Enables functionality like debug formatting of flags that exceed 64 bits. #56
alexcrichton commented 2017-02-10 20:39:57 -06:00 (Migrated from github.com)

This seems to only be used in the formatting pieces, and there could we just use $T instead of an explicit size? That way we could defer this decision entirely to downstream crates I think?

This seems to only be used in the formatting pieces, and there could we just use `$T` instead of an explicit size? That way we could defer this decision entirely to downstream crates I think?
astocko commented 2017-02-11 00:34:42 -06:00 (Migrated from github.com)

Implemented as suggested. The change does require absolute paths for custom types and type aliases.

Implemented as suggested. The change does require absolute paths for custom types and type aliases.
alexcrichton commented 2017-02-11 11:19:35 -06:00 (Migrated from github.com)

Oh right sorry I forgot about that :(, that's actually a pretty crucial reason for this feature.

In that case I guess we'll have to stick with an unstable feature

Oh right sorry I forgot about that :(, that's actually a pretty crucial reason for this feature. In that case I guess we'll have to stick with an unstable feature
astocko commented 2017-02-11 13:05:51 -06:00 (Migrated from github.com)

I will revert to my original PR. Any comments or suggestions?

I will revert to my original PR. Any comments or suggestions?
alexcrichton commented 2017-02-11 19:10:11 -06:00 (Migrated from github.com)

Looks like this may still be the requires-absolute-paths version?

Looks like this may still be the requires-absolute-paths version?
alexcrichton commented 2017-02-11 23:29:14 -06:00 (Migrated from github.com)

Thanks!

Thanks!
dtolnay commented 2017-03-07 11:21:12 -06:00 (Migrated from github.com)

#61 reimplements this in a different way that neither requires absolute paths nor a cfg to opt into u128 compatibility.

#61 reimplements this in a different way that neither requires absolute paths nor a cfg to opt into u128 compatibility.
Sign in to join this conversation.
No reviewers
No labels
bug
good first issue
No milestone
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
gh-bitflags/bitflags!57
No description provided.