Fix: Rectangular selection ignores scroll offset #435
No reviewers
Labels
No labels
Area-Accessibility
Area-Build
Area-CodeCompletion
Area-Document
Area-Documentation
Area-Editing
Area-Folding
Area-Highlighting
Area-i18n
Area-Indentation
Area-NetFx
Area-Rendering
Area-Search
Area-Snippets
dependencies
duplicate
Feedback Needed
help wanted
invalid
Issue-Bug
Issue-Discussion
Issue-Enhancement
Issue-Performance
Issue-Question
on-hold
Resolution-Answered
Resolution-By Design
Resolution-Duplicate
Resolution-Fixed
Resolution-Won't Fix
Up-for-Grabs
No milestone
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
gh-icsharpcode/AvalonEdit!435
Loading…
Reference in a new issue
No description provided.
Delete branch "fix-rect-selection-ignores-scrolloffset"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
An
AvaloniaEdituser has discovered a problem with rectangular selection when virtual space is enabled. See https://github.com/AvaloniaUI/AvaloniaEdit/issues/472.I provided a fix for
AvaloniaEdit: https://github.com/AvaloniaUI/AvaloniaEdit/pull/496AvalonEditshows the same problem. This PR implements the fix forAvalonEdit.Details:
When a selection extends beyond the visual line into the "virtual space" then the
BackgroundGeometryBuildercreates two segments per line. One for the visible text, and one for the virtual space.The segment for the virtual space didn't apply the scroll offset. This is now fixed.
Thank you for your contribution!