Added a property Resources to IAssembly and IUnresolvedAssembly.

erik-kallen commented

2013-08-19 12:51:26 -05:00

(Migrated from github.com)

This property contains all embedded (/resource csc command line option) and linked (/linkresource option) resources. There is also something known as an "asssembly-linked" resource, but this is not supported because my Google-fu has failed me in finding out what it actually is and how to create one.

As discussed in #133, no resource data is being kept in memory unless the GetResourceStream method is used.

This property contains all embedded (/resource csc command line option) and linked (/linkresource option) resources. There is also something known as an "asssembly-linked" resource, but this is not supported because my Google-fu has failed me in finding out what it actually is and how to create one. As discussed in #133, no resource data is being kept in memory unless the `GetResourceStream` method is used.

dgrunwald commented

2013-08-19 13:27:15 -05:00

(Migrated from github.com)

You don't need to add the string fileName parameter: you can get the full path to the assembly file from ModuleDefinition.FullyQualifiedName.

You don't need to add the `string fileName` parameter: you can get the full path to the assembly file from `ModuleDefinition.FullyQualifiedName`.

erik-kallen commented

2013-08-19 13:31:05 -05:00

(Migrated from github.com)

Thanks. I was looking for that, but I just couldn't find it.

dgrunwald commented

2013-08-19 13:34:49 -05:00

(Migrated from github.com)

For CSharpProjectContent, I think it's sufficient if you provide AddResource(IAssemblyResource) and RemoveResource(IAssemblyResource) methods. The concrete implementation of the interface in this case can be left to the caller (for example, the GetResourceStream method in SharpDevelop might read the resources from an open editor instead of accessing the file system).

Also, AssemblyDefinition.ReadAssembly will fail for non-primary modules; it's better to use ModuleDefinition.ReadModule

For `CSharpProjectContent`, I think it's sufficient if you provide `AddResource(IAssemblyResource)` and `RemoveResource(IAssemblyResource)` methods. The concrete implementation of the interface in this case can be left to the caller (for example, the `GetResourceStream` method in SharpDevelop might read the resources from an open editor instead of accessing the file system). Also, `AssemblyDefinition.ReadAssembly` will fail for non-primary modules; it's better to use `ModuleDefinition.ReadModule`

erik-kallen commented

2013-08-19 13:34:58 -05:00

(Migrated from github.com)