dns.conf: use built-in 'self' keyword instead of hardcoded IP #19
No reviewers
Labels
No labels
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
No milestone
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
gh-idlesauce/umtx2!19
Loading…
Reference in a new issue
No description provided.
Delete branch "harreh3iesh/fix/dns-conf-self-keyword"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Closes #18
What
One-line change to
dns.conf— replaces the hardcoded IP with theselfkeyword thatfakedns.pyalready supports viaRuleEngine2._replace_self(). It resolves to the host machine's LAN IP at runtime, so the config works out of the box without any manual editing.Why
Every new user has to edit this before anything works. With
selfthey don't have to touch it at all.No changes to
fakedns.pyor any other file — the feature was already there.View command line instructions
Checkout
From your project repository, check out a new branch and test the changes.Merge
Merge the changes and update on Forgejo.Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.