gh-intel/isa-l_crypto
Watch
1
0
Fork
You've already forked isa-l_crypto
 0
Code Issues 21 Pull requests 5 Releases 3 Wiki Activity

add more cmake support for riscv64 #180

Open
HeliC829 wants to merge 2 commits from HeliC829/master into master
pull from: HeliC829/master
merge into: gh-intel:master
Conversation 14 Commits 2 Files changed 4 +45 -3
HeliC829 commented 2026-09-18 12:34:44 -05:00 (Migrated from github.com)
No description provided.
HeliC829 commented 2026-09-20 00:18:33 -05:00 (Migrated from github.com)

cc @sunyuechi

cc @sunyuechi
sunyuechi (Migrated from github.com) reviewed 2026-09-20 01:08:42 -05:00
CMakeLists.txt
sunyuechi (Migrated from github.com) commented 2026-09-20 01:04:30 -05:00

This part should be moved into the earlier

elseif(CPU_AARCH64 OR CPU_RISCV64)

block.

This part should be moved into the earlier ``` elseif(CPU_AARCH64 OR CPU_RISCV64) ``` block.
cmake/mh_sha256.cmake
sunyuechi (Migrated from github.com) commented 2026-09-20 01:00:44 -05:00

Add #if HAVE_RVV in mh_sha256_block.c, then this can be a single line here, same as the other architectures?

Add #if HAVE_RVV in mh_sha256_block.c, then this can be a single line here, same as the other architectures?
cmake/mh_sha256.cmake
sunyuechi (Migrated from github.com) commented 2026-09-20 00:58:08 -05:00

unrelated blank-line

unrelated blank-line
HeliC829 (Migrated from github.com) reviewed 2026-09-20 13:12:23 -05:00
CMakeLists.txt
HeliC829 (Migrated from github.com) commented 2026-09-20 13:12:23 -05:00

done

done
HeliC829 (Migrated from github.com) reviewed 2026-09-20 13:12:29 -05:00
cmake/mh_sha256.cmake
HeliC829 (Migrated from github.com) commented 2026-09-20 13:12:29 -05:00

done

done
HeliC829 (Migrated from github.com) reviewed 2026-09-20 13:12:34 -05:00
cmake/mh_sha256.cmake
HeliC829 (Migrated from github.com) commented 2026-09-20 13:12:34 -05:00

done

done
sunyuechi (Migrated from github.com) reviewed 2026-09-20 20:16:48 -05:00
CMakeLists.txt
@ -126,3 +126,2 @@
elseif(CPU_AARCH64 OR CPU_RISCV64)
# Configure ASM for ARM and RISC-V (uses GAS with .S files)
# The RISC-V implementation can use RVV when the compiler supports emitting
sunyuechi (Migrated from github.com) commented 2026-09-20 20:16:45 -05:00

Wouldn't dropping set(CMAKE_ASM_FLAGS "${CMAKE_C_FLAGS} -D__ASSEMBLY__") like this break the build? (riscv64_multibinary.h)

Wouldn't dropping `set(CMAKE_ASM_FLAGS "${CMAKE_C_FLAGS} -D__ASSEMBLY__")` like this break the build? (riscv64_multibinary.h)
HeliC829 (Migrated from github.com) reviewed 2026-09-20 23:10:04 -05:00
CMakeLists.txt
@ -126,3 +126,2 @@
elseif(CPU_AARCH64 OR CPU_RISCV64)
# Configure ASM for ARM and RISC-V (uses GAS with .S files)
# The RISC-V implementation can use RVV when the compiler supports emitting
HeliC829 (Migrated from github.com) commented 2026-09-20 23:10:03 -05:00

done.

done.
sunyuechi (Migrated from github.com) reviewed 2026-09-21 05:53:06 -05:00
.github/workflows/ci.yml
@ -147,3 +147,15 @@ jobs:
run: cmake --build build --config Release --parallel
sunyuechi (Migrated from github.com) commented 2026-09-21 05:53:02 -05:00

try --parallel $(nproc), otherwise, on older cmake versions the tests run serially.

try `--parallel $(nproc)`, otherwise, on older cmake versions the tests run serially.
HeliC829 (Migrated from github.com) reviewed 2026-09-21 08:37:56 -05:00
.github/workflows/ci.yml
@ -147,3 +147,15 @@ jobs:
run: cmake --build build --config Release --parallel
HeliC829 (Migrated from github.com) commented 2026-09-21 08:37:56 -05:00

Only ctest needs to handle that, not cmake?

Only ctest needs to handle that, not cmake?
sunyuechi (Migrated from github.com) reviewed 2026-09-21 08:51:29 -05:00
.github/workflows/ci.yml
@ -147,3 +147,15 @@ jobs:
run: cmake --build build --config Release --parallel
sunyuechi (Migrated from github.com) commented 2026-09-21 08:51:28 -05:00

Yes, cmake passes -j to the build tool (make etc.), ctest test itself, and only newer versions support omitting

Yes, cmake passes -j to the build tool (make etc.), ctest test itself, and only newer versions support omitting
HeliC829 (Migrated from github.com) reviewed 2026-09-21 09:11:02 -05:00
.github/workflows/ci.yml
@ -147,3 +147,15 @@ jobs:
run: cmake --build build --config Release --parallel
HeliC829 (Migrated from github.com) commented 2026-09-21 09:11:01 -05:00

done

done
sunyuechi commented 2026-09-21 09:23:46 -05:00 (Migrated from github.com)

LGTM

LGTM
pablodelara (Migrated from github.com) reviewed 2026-09-22 01:30:11 -05:00
.github/workflows/ci.yml
@ -147,3 +147,15 @@ jobs:
run: cmake --build build --config Release --parallel
pablodelara (Migrated from github.com) commented 2026-09-22 01:30:11 -05:00

Looks like the system where this is run is not a Debian-based system, so apt-get is not available. @sunyuechi, I think this is not needed because CMake is already installed anyway, right?

Looks like the system where this is run is not a Debian-based system, so apt-get is not available. @sunyuechi, I think this is not needed because CMake is already installed anyway, right?
sunyuechi (Migrated from github.com) reviewed 2026-09-22 01:40:23 -05:00
.github/workflows/ci.yml
@ -147,3 +147,15 @@ jobs:
run: cmake --build build --config Release --parallel
sunyuechi (Migrated from github.com) commented 2026-09-22 01:40:23 -05:00

emm. this system is openEuler, which uses dnf, and cmake isn't installed either. Could you take a look? @HeliC829

emm. this system is openEuler, which uses dnf, and cmake isn't installed either. Could you take a look? @HeliC829
This pull request is broken due to missing fork information.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin 'HeliC829/master:HeliC829/master'
git switch 'HeliC829/master'

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch 'master'
git merge --no-ff 'HeliC829/master'
git switch 'HeliC829/master'
git rebase 'master'
git switch 'master'
git merge --ff-only 'HeliC829/master'
git switch 'HeliC829/master'
git rebase 'master'
git switch 'master'
git merge --no-ff 'HeliC829/master'
git switch 'master'
git merge --squash 'HeliC829/master'
git switch 'master'
git merge --ff-only 'HeliC829/master'
git switch 'master'
git merge 'HeliC829/master'
git push origin 'master'
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
announcement

   
bug

   
duplicate

   
enhancement

   
help wanted

   
invalid

   
Next release

   
question

   
sighting

   
wontfix
No labels
announcement
bug
duplicate
enhancement
help wanted
invalid
Next release
question
sighting
wontfix
Milestone
Clear milestone
No items
No milestone
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
gh-intel/isa-l_crypto!180
No description provided.