fix(storage): show sidecar version in installed payloads #87

Open

lucaszhongsj wants to merge 2 commits from lucaszhongsj/fix/installed-version-display into main

lucaszhongsj commented

2026-08-07 15:35:47 -05:00

(Migrated from github.com)

Problem

Payloads without a version string in the filename (e.g. kylin-core.elf, shadowmountplus.elf) show no version label in the Installed Payloads list, even though the sidecar metadata already contains a version field.

The dashboard's PayloadButton already passes the version via payloadMeta[filename].version, but the storage page's PayloadName was missing the same prop — so the two pages render the same payload inconsistently.

Fix

Pass payloadMeta[fileName]?.version to PayloadName in the installed list. Falls back to filename-based parsing when sidecar metadata is absent.

While here, also extract getDisplayName in App.jsx so loadPayload and makeCard share the same path-to-name conversion (previously duplicated inline).

Test plan

kylin-core.elf (no version in filename, sidecar version present) → now shows v1.3.1-community-lite
ftpsrv_v0.21.elf (version in filename) → still shows v0.21
npm run build and npm run lint clean

## Problem Payloads without a version string in the filename (e.g. `kylin-core.elf`, `shadowmountplus.elf`) show no version label in the Installed Payloads list, even though the sidecar metadata already contains a `version` field. The dashboard's `PayloadButton` already passes the version via `payloadMeta[filename].version`, but the storage page's `PayloadName` was missing the same prop — so the two pages render the same payload inconsistently. ## Fix Pass `payloadMeta[fileName]?.version` to `PayloadName` in the installed list. Falls back to filename-based parsing when sidecar metadata is absent. While here, also extract `getDisplayName` in App.jsx so `loadPayload` and `makeCard` share the same path-to-name conversion (previously duplicated inline). ## Test plan - `kylin-core.elf` (no version in filename, sidecar version present) → now shows `v1.3.1-community-lite` - `ftpsrv_v0.21.elf` (version in filename) → still shows `v0.21` - `npm run build` and `npm run lint` clean

This pull request is broken due to missing fork information.

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin 'lucaszhongsj/fix/installed-version-display:lucaszhongsj/fix/installed-version-display'

git switch 'lucaszhongsj/fix/installed-version-display'

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch 'main'

git merge --no-ff 'lucaszhongsj/fix/installed-version-display'

git switch 'lucaszhongsj/fix/installed-version-display'

git rebase 'main'

git switch 'main'

git merge --ff-only 'lucaszhongsj/fix/installed-version-display'

git switch 'lucaszhongsj/fix/installed-version-display'

git rebase 'main'

git switch 'main'

git merge --no-ff 'lucaszhongsj/fix/installed-version-display'

git switch 'main'

git merge --squash 'lucaszhongsj/fix/installed-version-display'