gh-jbevain/cecil
Watch
1
0
Fork
You've already forked cecil
 0
Code Issues 79 Pull requests 35 Releases 6 Wiki Activity

Unity's Windows Runtime changes #394

Merged
TautvydasZilys merged 13 commits from upstream-master-staging into master 2020-09-15 17:48:37 -05:00
Conversation 8 Commits 13 Files changed 19 +1401 -100
TautvydasZilys commented 2017-05-05 15:55:13 -05:00 (Migrated from github.com)
No description provided.
mrvoorhe commented 2019-12-10 08:41:16 -06:00 (Migrated from github.com)

@jbevain are there any changes you want to see before you would land this?

@jbevain are there any changes you want to see before you would land this?
jbevain commented 2019-12-10 11:58:15 -06:00 (Migrated from github.com)

@mrvoorhe @TautvydasZilys can't we all collectively pretend that winmd files don't exist?

@mrvoorhe @TautvydasZilys can't we all collectively pretend that winmd files don't exist?
mrvoorhe commented 2019-12-10 13:22:37 -06:00 (Migrated from github.com)

@jbevain you can. Sometimes I can 😄 and @TautvydasZilys never can.

My end goal is to reduce our custom changes to cecil as much as possible so that it is easier for us to track upstream master.

@jbevain Based on your own comment https://github.com/jbevain/cecil/issues/389#issuecomment-303771487 there is at least something in this PR that you are open to. Do you want us to break some pieces out of this PR?

@jbevain you can. Sometimes I can :smile: and @TautvydasZilys never can. My end goal is to reduce our custom changes to cecil as much as possible so that it is easier for us to track upstream master. @jbevain Based on your own comment https://github.com/jbevain/cecil/issues/389#issuecomment-303771487 there is at least something in this PR that you are open to. Do you want us to break some pieces out of this PR?
jbevain commented 2019-12-10 14:59:59 -06:00 (Migrated from github.com)

I think reducing or eliminating the difference between your version and upstream is a worthy goal.

I also fully trust Tautvydas. It's me the problem. Taking this means that I'll probably end up maintaining it from my retirement home, and I just don't understand anything related to those projections because I've never had to look into them. That makes me scared to take such a large change, because in the end I have no idea what I'm taking.

I think reducing or eliminating the difference between your version and upstream is a worthy goal. I also fully trust Tautvydas. It's me the problem. Taking this means that I'll probably end up maintaining it from my retirement home, and I just don't understand anything related to those projections because I've never had to look into them. That makes me scared to take such a large change, because in the end I have no idea what I'm taking.
jbevain commented 2019-12-10 15:10:02 -06:00 (Migrated from github.com)

The counter argument to that is we already landed part the support for winmd files, and that PR fixes it. So I might as well just take it already.

The counter argument to that is we already landed part the support for winmd files, and that PR fixes it. So I might as well just take it already.
mrvoorhe commented 2019-12-10 20:49:48 -06:00 (Migrated from github.com)

It sounds like you are making progress sorting out your dilemma with yourself. Keep it up!

It sounds like you are making progress sorting out your dilemma with yourself. Keep it up!
mrvoorhe commented 2019-12-28 18:21:10 -06:00 (Migrated from github.com)

‘Tis the season to click green merge buttons

‘Tis the season to click green merge buttons
jbevain commented 2020-09-15 17:49:03 -05:00 (Migrated from github.com)

Thanks for the quick fix folks, I'm glad we've been able to work diligently to get this merged.

Thanks for the quick fix folks, I'm glad we've been able to work diligently to get this merged.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
1.0

   
bug

   
enhancement

   
invalid
No labels
1.0
bug
enhancement
invalid
Milestone
Clear milestone
No items
No milestone
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
gh-jbevain/cecil!394
No description provided.