gh-jbevain/cecil
Watch
1
0
Fork
You've already forked cecil
 0
Code Issues 79 Pull requests 35 Releases 6 Wiki Activity

Invalid OpCode Fix #54

Closed
yocontra wants to merge 2 commits from master into master
pull from: master
merge into: gh-jbevain:master
Conversation 2 Commits 2 Files changed 28 +1516 -1397
yocontra commented 2011-01-28 12:30:50 -06:00 (Migrated from github.com)

I don't expect you to accept this I just wanted you to have a look at the code (I sent you a message about this before and you told me there was no way in hell it was practical)

Some other files were changed with misc. random crap but the invalid opcode fix is only around 10 lines and makes all opcodes that aren't initialized identified with Invalid and the control flow being the equivalent of a nop.

I don't expect you to accept this I just wanted you to have a look at the code (I sent you a message about this before and you told me there was no way in hell it was practical) Some other files were changed with misc. random crap but the invalid opcode fix is only around 10 lines and makes all opcodes that aren't initialized identified with Invalid and the control flow being the equivalent of a nop.
jbevain commented 2011-01-28 13:38:37 -06:00 (Migrated from github.com)

Hi! Indeed, as we discussed, I don't think this will pulled in for now. Also note that code has many whitespace changes, making it very hard to have a look at the actual diff.

Hi! Indeed, as we discussed, I don't think this will pulled in for now. Also note that code has many whitespace changes, making it very hard to have a look at the actual diff.
yocontra commented 2011-02-04 15:26:04 -06:00 (Migrated from github.com)

Ah yeah I must've gone through some stuff in resharper. Really it was only a 10 line quick-fix but I understand

Ah yeah I must've gone through some stuff in resharper. Really it was only a 10 line quick-fix but I understand

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
1.0

   
bug

   
enhancement

   
invalid
No labels
1.0
bug
enhancement
invalid
Milestone
Clear milestone
No items
No milestone
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
gh-jbevain/cecil!54
No description provided.