Fix invalid ComputeHash from ByteByffer array computation #622

2019-10-17T20:07:32-05:00

jeromelaban commented

2019-10-17 20:07:32 -05:00

(Migrated from github.com)

Addresses #770, where MVID computation in deterministic mode can be incorrect

jeromelaban commented

2019-10-17 20:22:52 -05:00

(Migrated from github.com)

@jbevain Is it expected that lots of tests are failing with this message ?

The assembly is built by a runtime newer than the currently loaded runtime, and cannot be loaded.

@jbevain Is it expected that lots of tests are failing with this message ? ``` The assembly is built by a runtime newer than the currently loaded runtime, and cannot be loaded. ```

marek-safar (Migrated from github.com) reviewed

2019-10-18 03:24:36 -05:00

Mono.Security.Cryptography/CryptoService.cs

					
				@ -148,3 +148,3 @@

								for (int i = 0; i < buffers.Length; i++) {

									crypto_stream.Write (buffers [0].buffer, 0, buffers [0].length);

									crypto_stream.Write (buffers [i].buffer, 0, buffers [i].length);

								}

ouch!

jbevain commented

2019-10-18 11:41:33 -05:00

(Migrated from github.com)

@jeromelaban thanks for the PR and for finding this.

Obviously the errors are unexpected. No idea what changed since it's been working fine, I suspect a change in the GitHub actions VM environment. I'll look into that, in the meantime, this should be good to go.

@jeromelaban thanks for the PR and for finding this. Obviously the errors are unexpected. No idea what changed since it's been working fine, I suspect a change in the GitHub actions VM environment. I'll look into that, in the meantime, this should be good to go.

👍 1

Sign in to join this conversation.

No reviewers