Fix locally scoped constant array #644

2020-01-30T00:34:06-06:00

SimonCropp commented

2020-01-30 00:34:06 -06:00

(Migrated from github.com)

@jbevain seems to me an array should be treated the same as a object type for this context?

SimonCropp commented

2020-01-30 00:34:46 -06:00

(Migrated from github.com)

put in a diff PR since i am confident the fail test verifies the scenario. but am uncertain about this as a fix

jbevain (Migrated from github.com) requested changes

2020-01-30 11:37:14 -06:00

Test/Mono.Cecil.Tests/ImageReadTests.cs

					
				@ -210,0 +211,4 @@

						public void LocallyScopedConstantArray ()

						{

							TestModule ("LocallyScopedConstantArray.dll", module => {

								Assert.IsTrue (module.HasDebugHeader);

We'd need to assert that the constant is indeed null in there.

jbevain commented

2020-01-30 11:37:38 -06:00

(Migrated from github.com)

Thanks for the PR. The fix is good!

SimonCropp (Migrated from github.com) reviewed

2020-01-30 16:27:34 -06:00

Test/Mono.Cecil.Tests/ImageReadTests.cs

					
				@ -210,0 +211,4 @@

						public void LocallyScopedConstantArray ()

						{

							TestModule ("LocallyScopedConstantArray.dll", module => {

								Assert.IsTrue (module.HasDebugHeader);