Changing PdbReaderProvider to accept create EmbeddedPDB from stream. #648
Loading…
Reference in a new issue
No description provided.
Delete branch "thays_read_embedded_pdb"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Changing GetSymbolReader from PdbReaderProvider, when we create a Module from stream we don't have the filename, and it's not necessary to create an EmbeddedPortablePdbReaderProvider, so I've moved the check to after the creation of EmbeddedPortablePdbReaderProvider.
Thank you for your contribution! Please just address the comment and this will be good to go.
@ -368,6 +369,33 @@ namespace Mono.Cecil.Tests {}, symbolReaderProvider: typeof (EmbeddedPortablePdbReaderProvider), symbolWriterProvider: typeof (EmbeddedPortablePdbWriterProvider));I think we can make this simpler and not create infrastructure for reading modules as in memory. You can undo all the changes in BaseTestFixture, and in this test you can use:
var bytes = File.ReadAllBytes (GetAssemblyResourcePath ("EmbeddedCompressedPdbTarget.exe"))Create the module from that and run the test.
@ -368,6 +369,33 @@ namespace Mono.Cecil.Tests {}, symbolReaderProvider: typeof (EmbeddedPortablePdbReaderProvider), symbolWriterProvider: typeof (EmbeddedPortablePdbWriterProvider));Done!
Thank you!