gh-jbevain/cecil
Watch
1
0
Fork
You've already forked cecil
 0
Code Issues 79 Pull requests 35 Releases 6 Wiki Activity

Fix ReadSymbols in a Module that is already created #686

Merged
thaystg merged 4 commits from thays_fix_readsymbols_late into master 2020-09-15 17:59:30 -05:00
Conversation 5 Commits 4 Files changed 4 +23 -1
thaystg commented 2020-08-11 19:53:30 -05:00 (Migrated from github.com)

When I try to use ReadSymbols in a Module that is already created, for example:

var symbolReader = portablePdbReaderProvider.GetSymbolReader(asm.image, stream);
asm.image.ReadSymbols(symbolReader);

method.debug_info has a list, but it's empty, so it wasn't entering in the if, but it should, maybe we should change the if to method.debug_info == null || method.debug_info.count = 0.

Relates to this PR: https://github.com/dotnet/runtime/pull/40690

When I try to use ReadSymbols in a Module that is already created, for example: ``` var symbolReader = portablePdbReaderProvider.GetSymbolReader(asm.image, stream); asm.image.ReadSymbols(symbolReader); ``` method.debug_info has a list, but it's empty, so it wasn't entering in the if, but it should, maybe we should change the if to method.debug_info == null || method.debug_info.count = 0. Relates to this PR: https://github.com/dotnet/runtime/pull/40690
jbevain commented 2020-08-12 11:34:45 -05:00 (Migrated from github.com)

Hi @thaystg, good to see you here.

Could you add a unit test that reproduces your scenario?

Hi @thaystg, good to see you here. Could you add a unit test that reproduces your scenario?
thaystg commented 2020-08-14 12:13:38 -05:00 (Migrated from github.com)

Hi @thaystg, good to see you here.

Could you add a unit test that reproduces your scenario?

Done!!! :)

> Hi @thaystg, good to see you here. > > Could you add a unit test that reproduces your scenario? Done!!! :)
thaystg commented 2020-09-15 08:57:25 -05:00 (Migrated from github.com)

@jbevain could you please merge and generate a new nuget version? We need this for wasm debug.

@jbevain could you please merge and generate a new nuget version? We need this for wasm debug.
jbevain commented 2020-09-15 17:59:38 -05:00 (Migrated from github.com)

Thanks!

Thanks!
jbevain commented 2020-09-15 18:42:38 -05:00 (Migrated from github.com)

@thaystg the fix shipped in 0.11.3. Thanks!

@thaystg the fix shipped in 0.11.3. Thanks!
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
1.0

   
bug

   
enhancement

   
invalid
No labels
1.0
bug
enhancement
invalid
Milestone
Clear milestone
No items
No milestone
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
gh-jbevain/cecil!686
No description provided.