gh-jbevain/cecil
Watch
1
0
Fork
You've already forked cecil
 0
Code Issues 79 Pull requests 35 Releases 6 Wiki Activity

Fix type reference name in attribute argument getting mangled when #722

Merged
mrvoorhe merged 1 commit from master-winrt-fix into master 2021-02-11 17:46:59 -06:00
Conversation 9 Commits 1 Files changed 5 +42 -3
mrvoorhe commented 2021-02-09 14:54:54 -06:00 (Migrated from github.com)

such attribute is put on a method in a projected type.

This is a fix that Unity's cecil has had for a couple years.

such attribute is put on a method in a projected type. This is a fix that Unity's cecil has had for a couple years.
jbevain (Migrated from github.com) reviewed 2021-02-09 15:39:08 -06:00
Test/Mono.Cecil.Tests/TypeParserTests.cs
@ -88,7 +88,7 @@ namespace Mono.Cecil.Tests {
public void FullyQualifiedTypeReference ()
jbevain (Migrated from github.com) commented 2021-02-09 15:39:08 -06:00

Nope :)

Nope :)
mrvoorhe (Migrated from github.com) reviewed 2021-02-10 08:44:34 -06:00
Test/Mono.Cecil.Tests/TypeParserTests.cs
@ -88,7 +88,7 @@ namespace Mono.Cecil.Tests {
public void FullyQualifiedTypeReference ()
mrvoorhe (Migrated from github.com) commented 2021-02-10 08:44:34 -06:00

Fixed

Fixed
mrvoorhe commented 2021-02-10 09:28:34 -06:00 (Migrated from github.com)

I can't tell if a test failed or if there was some CI instability. All I see in the log is

  Determining projects to restore...
D:\a\cecil\cecil\symbols\pdb\Mono.Cecil.Pdb.csproj : error NU1101: Unable to find package Microsoft.SourceLink.GitHub. No packages exist with this id in source(s): Microsoft Visual Studio Offline Packages [D:\a\cecil\cecil\Mono.Cecil.sln]
D:\a\cecil\cecil\symbols\pdb\Mono.Cecil.Pdb.csproj : error NU1101: Unable to find package Microsoft.NETFramework.ReferenceAssemblies.net40. No packages exist with this id in source(s): Microsoft Visual Studio Offline Packages [D:\a\cecil\cecil\Mono.Cecil.sln]
  Failed to restore D:\a\cecil\cecil\symbols\pdb\Mono.Cecil.Pdb.csproj (in 1.1 sec).
  Restored D:\a\cecil\cecil\symbols\pdb\Test\Mono.Cecil.Pdb.Tests.csproj (in 49.83 sec).
  Restored D:\a\cecil\cecil\symbols\mdb\Test\Mono.Cecil.Mdb.Tests.csproj (in 48.71 sec).
  Restored D:\a\cecil\cecil\symbols\mdb\Mono.Cecil.Mdb.csproj (in 7 ms).
  Restored D:\a\cecil\cecil\Test\Mono.Cecil.Tests.csproj (in 125 ms).
  Restored D:\a\cecil\cecil\rocks\Mono.Cecil.Rocks.csproj (in 5 ms).
  Restored D:\a\cecil\cecil\rocks\Test\Mono.Cecil.Rocks.Tests.csproj (in 127 ms).
  Restored D:\a\cecil\cecil\Mono.Cecil.csproj (in 5 ms).

Build FAILED.
I can't tell if a test failed or if there was some CI instability. All I see in the log is ``` Determining projects to restore... D:\a\cecil\cecil\symbols\pdb\Mono.Cecil.Pdb.csproj : error NU1101: Unable to find package Microsoft.SourceLink.GitHub. No packages exist with this id in source(s): Microsoft Visual Studio Offline Packages [D:\a\cecil\cecil\Mono.Cecil.sln] D:\a\cecil\cecil\symbols\pdb\Mono.Cecil.Pdb.csproj : error NU1101: Unable to find package Microsoft.NETFramework.ReferenceAssemblies.net40. No packages exist with this id in source(s): Microsoft Visual Studio Offline Packages [D:\a\cecil\cecil\Mono.Cecil.sln] Failed to restore D:\a\cecil\cecil\symbols\pdb\Mono.Cecil.Pdb.csproj (in 1.1 sec). Restored D:\a\cecil\cecil\symbols\pdb\Test\Mono.Cecil.Pdb.Tests.csproj (in 49.83 sec). Restored D:\a\cecil\cecil\symbols\mdb\Test\Mono.Cecil.Mdb.Tests.csproj (in 48.71 sec). Restored D:\a\cecil\cecil\symbols\mdb\Mono.Cecil.Mdb.csproj (in 7 ms). Restored D:\a\cecil\cecil\Test\Mono.Cecil.Tests.csproj (in 125 ms). Restored D:\a\cecil\cecil\rocks\Mono.Cecil.Rocks.csproj (in 5 ms). Restored D:\a\cecil\cecil\rocks\Test\Mono.Cecil.Rocks.Tests.csproj (in 127 ms). Restored D:\a\cecil\cecil\Mono.Cecil.csproj (in 5 ms). Build FAILED. ```
mrvoorhe commented 2021-02-11 07:14:04 -06:00 (Migrated from github.com)

Looks like it was a CI instability. I force pushed to trigger a new CI run and now the tests are green.

Looks like it was a CI instability. I force pushed to trigger a new CI run and now the tests are green.
jbevain commented 2021-02-11 10:58:24 -06:00 (Migrated from github.com)

Yeah that's NuGet having hiccups.

Yeah that's NuGet having hiccups.
jbevain (Migrated from github.com) reviewed 2021-02-11 11:09:44 -06:00
Mono.Cecil/AssemblyWriter.cs
@ -2998,6 +2998,27 @@ namespace Mono.Cecil {
}
jbevain (Migrated from github.com) commented 2021-02-11 11:09:44 -06:00

Could you move this into the if branch?

Could you move this into the if branch?
mrvoorhe (Migrated from github.com) reviewed 2021-02-11 12:53:21 -06:00
Mono.Cecil/AssemblyWriter.cs
@ -2998,6 +2998,27 @@ namespace Mono.Cecil {
}
mrvoorhe (Migrated from github.com) commented 2021-02-11 12:53:21 -06:00

Done

Done
jbevain (Migrated from github.com) approved these changes 2021-02-11 17:46:30 -06:00
jbevain commented 2021-02-11 17:47:04 -06:00 (Migrated from github.com)

Thank you!

Thank you!
Sign in to join this conversation.
Reviewers
No reviewers
jbevain
Labels
Clear labels   
1.0

   
bug

   
enhancement

   
invalid
No labels
1.0
bug
enhancement
invalid
Milestone
Clear milestone
No items
No milestone
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
gh-jbevain/cecil!722
No description provided.