gh-jbevain/cecil
Watch
1
0
Fork
You've already forked cecil
 0
Code Issues 79 Pull requests 35 Releases 6 Wiki Activity

Add importing of netmodule #819

Open
kant2002 wants to merge 2 commits from kant2002/kant/import-netmodule into master
pull from: kant2002/kant/import-netmodule
merge into: gh-jbevain:master
Conversation 6 Commits 2 Files changed 2 +61 -2
kant2002 commented 2021-12-12 22:49:01 -06:00 (Migrated from github.com)

Closes #818

Closes #818
jbevain commented 2022-01-12 18:14:53 -06:00 (Migrated from github.com)

Hi @kant2002! Thank you for your PR!

Is this an actual case you're hitting? While the code seems to make sense, could you add tests for it?

Thanks!

Hi @kant2002! Thank you for your PR! Is this an actual case you're hitting? While the code seems to make sense, could you add tests for it? Thanks!
kant2002 commented 2022-01-13 01:08:17 -06:00 (Migrated from github.com)

@jbevain I was hitting that in the actual snippet which I wrote in the issue. That snipped was created by @fornever when he play with C compiler in .NET. He probably can explain more.

Regarding tests, what's proper place to add test for this case? I was looking for them, but I cannot find nice place where I can validate case.

@jbevain I was hitting that in the actual snippet which I wrote in the issue. That snipped was created by @fornever when he play with C compiler in .NET. He probably can explain more. Regarding tests, what's proper place to add test for this case? I was looking for them, but I cannot find nice place where I can validate case.
jbevain commented 2022-01-13 15:04:23 -06:00 (Migrated from github.com)

Hey!

The place to add a test would be there:

https://github.com/jbevain/cecil/blob/master/Test/Mono.Cecil.Tests/ImportCecilTests.cs

Thanks!

Hey! The place to add a test would be there: https://github.com/jbevain/cecil/blob/master/Test/Mono.Cecil.Tests/ImportCecilTests.cs Thanks!
ForNeVeR commented 2022-01-15 10:02:02 -06:00 (Migrated from github.com)

That snipped was created by @ForNeVeR when he play with C compiler in .NET. He probably can explain more.

This was an experiment while I was investigating how to create/use a .netmodule file using Cecil (in a project where I'm trying to create a fully C17-compatible compiler using Cecil, among other tools).

Initially, I wanted to mimic the full C-style compilation: creating a separate .netmodule for every translation unit, and then linking them together using the .NET assembly linker (al.exe, IIRC).

Though right now I've deserted this approach (not because of any Cecil problems, but because I don't think it's appropriate). So, there are no any actual uses of .netmodules in my code at the moment.

It not impossible I'll decide to play with them again later, but not too likely, either.

> That snipped was created by @ForNeVeR when he play with C compiler in .NET. He probably can explain more. This was an experiment while I was investigating how to create/use a `.netmodule` file using Cecil (in a project where I'm trying to create a fully C17-compatible compiler using Cecil, among other tools). Initially, I wanted to mimic the full C-style compilation: creating a separate `.netmodule` for every translation unit, and then linking them together using the .NET assembly linker (`al.exe`, IIRC). Though right now I've deserted this approach (not because of any Cecil problems, but because I don't think it's appropriate). So, there are no any actual uses of `.netmodule`s in my code at the moment. It not impossible I'll decide to play with them again later, but not too likely, either.
kant2002 commented 2022-01-17 11:29:09 -06:00 (Migrated from github.com)

@jbevain I think this is ready for another round of review.

@jbevain I think this is ready for another round of review.
kant2002 commented 2023-12-14 01:38:15 -06:00 (Migrated from github.com)

@jbevain New year is soon. I behave well, so may I have some present on New Year, or on Christmas ?

@jbevain New year is soon. I behave well, so may I have some present on New Year, or on Christmas ?
👍 1
This pull request is broken due to missing fork information.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin 'kant2002/kant/import-netmodule:kant2002/kant/import-netmodule'
git switch 'kant2002/kant/import-netmodule'

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch 'master'
git merge --no-ff 'kant2002/kant/import-netmodule'
git switch 'kant2002/kant/import-netmodule'
git rebase 'master'
git switch 'master'
git merge --ff-only 'kant2002/kant/import-netmodule'
git switch 'kant2002/kant/import-netmodule'
git rebase 'master'
git switch 'master'
git merge --no-ff 'kant2002/kant/import-netmodule'
git switch 'master'
git merge --squash 'kant2002/kant/import-netmodule'
git switch 'master'
git merge --ff-only 'kant2002/kant/import-netmodule'
git switch 'master'
git merge 'kant2002/kant/import-netmodule'
git push origin 'master'
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
1.0

   
bug

   
enhancement

   
invalid
No labels
1.0
bug
enhancement
invalid
Milestone
Clear milestone
No items
No milestone
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
gh-jbevain/cecil!819
No description provided.