gh-jbevain/cecil
Watch
1
0
Fork
You've already forked cecil
 0
Code Issues 79 Pull requests 35 Releases 6 Wiki Activity

Fix mixed module ReadSymbols() #851

Merged
MarcoRossignoli merged 4 commits from fixmixedmodulereadsymbol into master 2022-06-14 22:12:53 -05:00
Conversation 2 Commits 4 Files changed 5 +24 -10
MarcoRossignoli commented 2022-06-01 08:16:10 -05:00 (Migrated from github.com)

If we try to read symbols for mixed module(native/CLI) we got this exception:

image

I noticed that in the same file there's already a "check" commented out(lines 49,51), we need only to be good for the read(sequence points) and we don't need to write mixed module(is not supported).

cc: @jakubch1 @fhnaseer

If we try to read symbols for mixed module(native/CLI) we got this exception: <img width="976" alt="image" src="https://user-images.githubusercontent.com/7894084/171412792-c5053bcb-42a7-431b-bcce-e848b9cb5b94.png"> I noticed that in the same file there's already a "check" commented out(lines 49,51), we need only to be good for the read(sequence points) and we don't need to write mixed module(is not supported). cc: @jakubch1 @fhnaseer
MarcoRossignoli commented 2022-06-01 09:11:29 -05:00 (Migrated from github.com)

@jbevain is it possible run tests from a Draft?

@jbevain is it possible run tests from a Draft?
jbevain commented 2022-06-14 22:13:05 -05:00 (Migrated from github.com)

Thanks for the PR @MarcoRossignoli!

Thanks for the PR @MarcoRossignoli!
❤️ 1
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
1.0

   
bug

   
enhancement

   
invalid
No labels
1.0
bug
enhancement
invalid
Milestone
Clear milestone
No items
No milestone
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
gh-jbevain/cecil!851
No description provided.