gh-jbevain/cecil
Watch
1
0
Fork
You've already forked cecil
 0
Code Issues 79 Pull requests 35 Releases 6 Wiki Activity

Add more style configuration #854

Merged
Zastai merged 1 commit from more-style-configuration into master 2022-09-29 16:10:32 -05:00
Conversation 5 Commits 1 Files changed 1 +13 -1
Zastai commented 2022-06-10 18:22:08 -05:00 (Migrated from github.com)

This sets up .NET naming for fields, locals and parameters to use
snake_case, so that editors won't complain about those.

It also disables trimming of trailing blanks to avoid accidentally
including such whitespace diffs in PRs.

This sets up .NET naming for fields, locals and parameters to use snake_case, so that editors won't complain about those. It also disables trimming of trailing blanks to avoid accidentally including such whitespace diffs in PRs.
jbevain (Migrated from github.com) reviewed 2022-06-14 22:16:44 -05:00
.editorconfig
@ -12,0 +12,4 @@
trim_trailing_whitespace = false
dotnet_naming_symbols.fields_locals_and_parameters.applicable_kinds = field, local, parameter
jbevain (Migrated from github.com) commented 2022-06-14 22:16:44 -05:00

That should be true no? We don't want trailing whitespaces.

That should be `true` no? We don't want trailing whitespaces.
SimonCropp (Migrated from github.com) reviewed 2022-06-14 23:27:06 -05:00
.editorconfig
@ -12,0 +12,4 @@
trim_trailing_whitespace = false
dotnet_naming_symbols.fields_locals_and_parameters.applicable_kinds = field, local, parameter
SimonCropp (Migrated from github.com) commented 2022-06-14 23:27:06 -05:00

@jbevain i assume @Zastai was trying to define a config that most closely matches the current codebase. given there are existing trailing whitespaces, the assumption is trim_trailing_whitespace = false

@jbevain i assume @Zastai was trying to define a config that most closely matches the current codebase. given there are existing trailing whitespaces, the assumption is `trim_trailing_whitespace = false`
Zastai (Migrated from github.com) reviewed 2022-06-15 08:12:34 -05:00
.editorconfig
@ -12,0 +12,4 @@
trim_trailing_whitespace = false
dotnet_naming_symbols.fields_locals_and_parameters.applicable_kinds = field, local, parameter
Zastai (Migrated from github.com) commented 2022-06-15 08:12:33 -05:00

Exactly. I got a spurious diff for a PR because Rider had trimmed existing trailing white space.

If the intent is not to have trailing whitespace and it's ok for a PR to include such a change, then by all means set it to true.

Exactly. I got a spurious diff for a PR because Rider had trimmed existing trailing white space. If the intent is not to have trailing whitespace and it's ok for a PR to include such a change, then by all means set it to true.
jbevain (Migrated from github.com) reviewed 2022-09-29 16:10:19 -05:00
.editorconfig
@ -12,0 +12,4 @@
trim_trailing_whitespace = false
dotnet_naming_symbols.fields_locals_and_parameters.applicable_kinds = field, local, parameter
jbevain (Migrated from github.com) commented 2022-09-29 16:10:19 -05:00

Ah got it, makes sense. Thanks. Yeah let's land this one like this, I'll definitely take a follow-up PR that trims trailing whitespaces.

Ah got it, makes sense. Thanks. Yeah let's land this one like this, I'll definitely take a follow-up PR that trims trailing whitespaces.
jbevain commented 2022-09-29 16:10:27 -05:00 (Migrated from github.com)

Thank you!

Thank you!
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
1.0

   
bug

   
enhancement

   
invalid
No labels
1.0
bug
enhancement
invalid
Milestone
Clear milestone
No items
No milestone
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
gh-jbevain/cecil!854
No description provided.