Fix issue with 0xffff parameters

jbevain commented

2023-06-23 17:21:52 -05:00

(Migrated from github.com)

Fix #913

alexey-zakharov commented

2024-11-04 02:44:23 -06:00

(Migrated from github.com)

Hey @jbevain !

Are there any reasons to not merge this PR? 😄

Hey @jbevain ! Are there any reasons to not merge this PR? 😄

xoofx commented

2024-12-16 10:07:12 -06:00

(Migrated from github.com)

Hey @jbevain, After discussing with @alexey-zakharov we believe that it is the right fix. We did a similar fix in https://github.com/Unity-Technologies/mono/pull/2081, it is non breaking and fixing an actual issue. We plan to port also this fix to CoreCLR. Could you merge this PR and release a new package?

ItsZil commented

2026-03-10 10:32:38 -05:00

(Migrated from github.com)

Hi @jbevain, I put up PR #977, which changes your fix very slightly to fix cases where there is an overflow due to extra parameterless methods. Can you please check whether that fix could be merged instead of this one? Thanks 🙂

This pull request can be merged automatically.

You are not authorized to merge this pull request.

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin 'param0xffff:param0xffff'

git switch 'param0xffff'

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch 'master'

git merge --no-ff 'param0xffff'

git switch 'param0xffff'

git rebase 'master'

git switch 'master'

git merge --ff-only 'param0xffff'

git switch 'param0xffff'

git rebase 'master'

git switch 'master'

git merge --no-ff 'param0xffff'

git switch 'master'

git merge --squash 'param0xffff'

git switch 'master'

git merge --ff-only 'param0xffff'

git switch 'master'

git merge 'param0xffff'

git push origin 'master'

Rows
Columns

Fix issue with 0xffff parameters #914

Checkout

Merge