gh-jbevain/cecil
Watch
1
0
Fork
You've already forked cecil
 0
Code Issues 79 Pull requests 35 Releases 6 Wiki Activity

Dispose IDisposables in NativePdbWriter #952

Open
omajid wants to merge 1 commit from omajid/dispose-resources-nativepdbwriter into master
pull from: omajid/dispose-resources-nativepdbwriter
merge into: gh-jbevain:master
Conversation 0 Commits 1 Files changed 1 +2 -1
omajid commented 2024-06-20 09:21:26 -05:00 (Migrated from github.com)

  • The code creates a local variable that's an IDisposable (CustomMetadataWriter), but doesn't call Dispose() on it.

  • The CustomMetadataWriter class holds two IDisposables (MemoryStream and BinaryStreamWriter), but was only Dispose()ing one of them.

- The code creates a local variable that's an IDisposable (CustomMetadataWriter), but doesn't call Dispose() on it. - The CustomMetadataWriter class holds two IDisposables (MemoryStream and BinaryStreamWriter), but was only Dispose()ing one of them.
This pull request is broken due to missing fork information.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin 'omajid/dispose-resources-nativepdbwriter:omajid/dispose-resources-nativepdbwriter'
git switch 'omajid/dispose-resources-nativepdbwriter'

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch 'master'
git merge --no-ff 'omajid/dispose-resources-nativepdbwriter'
git switch 'omajid/dispose-resources-nativepdbwriter'
git rebase 'master'
git switch 'master'
git merge --ff-only 'omajid/dispose-resources-nativepdbwriter'
git switch 'omajid/dispose-resources-nativepdbwriter'
git rebase 'master'
git switch 'master'
git merge --no-ff 'omajid/dispose-resources-nativepdbwriter'
git switch 'master'
git merge --squash 'omajid/dispose-resources-nativepdbwriter'
git switch 'master'
git merge --ff-only 'omajid/dispose-resources-nativepdbwriter'
git switch 'master'
git merge 'omajid/dispose-resources-nativepdbwriter'
git push origin 'master'
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
1.0

   
bug

   
enhancement

   
invalid
No labels
1.0
bug
enhancement
invalid
Milestone
Clear milestone
No items
No milestone
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
gh-jbevain/cecil!952
No description provided.