Fix off-by-one bug in ModuleMetadata #979

Open
Alexx999 wants to merge 1 commit from Alexx999/pr/pdb-native-off-by-one into master
Alexx999 commented 2026-03-15 06:27:22 -05:00 (Migrated from github.com)

Looking at the code closely, i is equal to length - 1 at the end of the cycle, so "next char" would be just "length"

Looking at the code closely, i is equal to length - 1 at the end of the cycle, so "next char" would be just "length"
This pull request is broken due to missing fork information.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin 'Alexx999/pr/pdb-native-off-by-one:Alexx999/pr/pdb-native-off-by-one'
git switch 'Alexx999/pr/pdb-native-off-by-one'

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch 'master'
git merge --no-ff 'Alexx999/pr/pdb-native-off-by-one'
git switch 'Alexx999/pr/pdb-native-off-by-one'
git rebase 'master'
git switch 'master'
git merge --ff-only 'Alexx999/pr/pdb-native-off-by-one'
git switch 'Alexx999/pr/pdb-native-off-by-one'
git rebase 'master'
git switch 'master'
git merge --no-ff 'Alexx999/pr/pdb-native-off-by-one'
git switch 'master'
git merge --squash 'Alexx999/pr/pdb-native-off-by-one'
git switch 'master'
git merge --ff-only 'Alexx999/pr/pdb-native-off-by-one'
git switch 'master'
git merge 'Alexx999/pr/pdb-native-off-by-one'
git push origin 'master'
Sign in to join this conversation.
No reviewers
No milestone
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
gh-jbevain/cecil!979
No description provided.