gh-libtom/libtomcrypt
Watch
1
0
Fork
You've already forked libtomcrypt
 0
Code Issues 42 Pull requests 17 Releases 9 Wiki Activity

Visualstudio solution #517

Open
FredeJ wants to merge 3 commits from FredeJ/visualstudio_solution into develop
pull from: FredeJ/visualstudio_solution
merge into: gh-libtom:develop
Conversation 9 Commits 3 Files changed 7 +2564 -2924
FredeJ commented 2019-10-25 08:48:33 -05:00 (Migrated from github.com)

Migrate the solution file to Visual Studio 15.

The goal of this is to allow libtomcrypt to be made available through vcpkg (https://github.com/microsoft/vcpkg/)

Migrate the solution file to Visual Studio 15. The goal of this is to allow libtomcrypt to be made available through vcpkg (https://github.com/microsoft/vcpkg/)
karel-m (Migrated from github.com) reviewed 2019-10-25 08:48:33 -05:00
karel-m commented 2019-10-25 10:13:08 -05:00 (Migrated from github.com)

👎 While you are able to import the old format (VS2008) into newer Visual Studio (e.g. VS2015) it is not possible the other way around. I am for keeping VS2008 compatibility.

👎 While you are able to import the old format (VS2008) into newer Visual Studio (e.g. VS2015) it is not possible the other way around. I am for keeping VS2008 compatibility.
sjaeckel commented 2019-10-25 10:47:45 -05:00 (Migrated from github.com)

@FredeJ is it an option to use the makefile.msvc for your purpose?

@FredeJ is it an option to use the `makefile.msvc` for your purpose?
karel-m commented 2019-10-25 11:01:01 -05:00 (Migrated from github.com)

No, makefile.msvc is not what I want.

The other thing is that it is not sufficient to just save the original .vcproj as .vcxproj. Somebody has also update helper.pl so that the .vcxproj file is updated when a new source file is added, deleted or renamed.

No, makefile.msvc is not what I want. The other thing is that it is not sufficient to just save the original `.vcproj` as `.vcxproj`. Somebody has also update `helper.pl` so that the `.vcxproj` file is updated when a new source file is added, deleted or renamed.
sjaeckel commented 2019-10-25 11:05:30 -05:00 (Migrated from github.com)

No, makefile.msvc is not what I want.

I asked @FredeJ ;-)

The other thing is that it is not sufficient to just save the original .vcproj as .vcxproj. Somebody has also update helper.pl so that the .vcxproj file is updated when a new source file is added, deleted or renamed.

Right, I thought that was done, but apparently it wasn't.

> No, makefile.msvc is not what I want. I asked @FredeJ ;-) > The other thing is that it is not sufficient to just save the original `.vcproj` as `.vcxproj`. Somebody has also update `helper.pl` so that the `.vcxproj` file is updated when a new source file is added, deleted or renamed. Right, I thought that was done, but apparently it wasn't.
karel-m commented 2019-10-25 11:45:15 -05:00 (Migrated from github.com)

I will support this PR only when it keeps support for both cases:

  • libtomcrypt_VS2008.sln + libtomcrypt_VS2008.vcproj
  • libtomcrypt_VS2015.sln + libtomcrypt_VS2015.vcxproj (not sure about having .vcxproj.filters in git)

But again, somebody has to fix helper.pl so that it is able to update .vcxproj.

I will support this PR only when it keeps support for both cases: * `libtomcrypt_VS2008.sln` + `libtomcrypt_VS2008.vcproj` * `libtomcrypt_VS2015.sln` + `libtomcrypt_VS2015.vcxproj` (not sure about having .vcxproj.filters in git) But again, somebody has to fix `helper.pl` so that it is able to update .vcxproj.
👍 1
FredeJ commented 2019-10-28 08:12:37 -05:00 (Migrated from github.com)

@sjaeckel makefile.msvc seems to be able to get me basically 95% there. I was not aware of nmake at all but was just using msbuild, which failed with the older project and solution files.

Now all I'm missing is figuring out how to build both debug and release, and both libtomcrypt and libtommath should be buildable with vcpkg :)

@sjaeckel `makefile.msvc` seems to be able to get me basically 95% there. I was not aware of `nmake` at all but was just using `msbuild`, which failed with the older project and solution files. Now all I'm missing is figuring out how to build both debug and release, and both libtomcrypt and libtommath should be buildable with vcpkg :)
sjaeckel commented 2019-10-28 08:18:25 -05:00 (Migrated from github.com)

@sjaeckel makefile.msvc seems to be able to get me basically 95% there

cool :)

Now all I'm missing is figuring out how to build both debug and release, and both libtomcrypt and libtommath should be buildable with vcpkg :)

uhm, pass in some CFLAGS and change the libname for the debug build? something like nmake -f makefile.msvc CFLAGS="-MTd" LIBMAIN_S="tomcrypt-debug.lib"

I don't run windows, so I can't tell if it's exactly like that, but that should give you a direction

> @sjaeckel `makefile.msvc` seems to be able to get me basically 95% there cool :) > Now all I'm missing is figuring out how to build both debug and release, and both libtomcrypt and libtommath should be buildable with vcpkg :) uhm, pass in some CFLAGS and change the libname for the debug build? something like `nmake -f makefile.msvc CFLAGS="-MTd" LIBMAIN_S="tomcrypt-debug.lib"` I don't run windows, so I can't tell if it's exactly like that, but that should give you a direction
enginelesscc commented 2025-09-20 17:23:41 -05:00 (Migrated from github.com)

👎 While you are able to import the old format (VS2008) into newer Visual Studio (e.g. VS2015) it is not possible the other way around. I am for keeping VS2008 compatibility.

Fyi, as of at least VS2022 (possibly earlier), upgrading does no longer work and its impossible to use these relict-vs solution files.

Upgrading these solution files to at least VS2010 will fix that.

> 👎 While you are able to import the old format (VS2008) into newer Visual Studio (e.g. VS2015) it is not possible the other way around. I am for keeping VS2008 compatibility. Fyi, as of **at least** VS2022 (possibly earlier), upgrading does no longer work and its impossible to use these relict-vs solution files. Upgrading these solution files to at least VS2010 will fix that.
This pull request has changes conflicting with the target branch.
  • libtomcrypt_VS2008.vcproj
  • updatemakes.sh
View command line instructions

Manual merge helper

Use this merge commit message when completing the merge manually.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin 'FredeJ/visualstudio_solution:FredeJ/visualstudio_solution'
git switch 'FredeJ/visualstudio_solution'

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch 'develop'
git merge --no-ff 'FredeJ/visualstudio_solution'
git switch 'FredeJ/visualstudio_solution'
git rebase 'develop'
git switch 'develop'
git merge --ff-only 'FredeJ/visualstudio_solution'
git switch 'FredeJ/visualstudio_solution'
git rebase 'develop'
git switch 'develop'
git merge --no-ff 'FredeJ/visualstudio_solution'
git switch 'develop'
git merge --squash 'FredeJ/visualstudio_solution'
git switch 'develop'
git merge --ff-only 'FredeJ/visualstudio_solution'
git switch 'develop'
git merge 'FredeJ/visualstudio_solution'
git push origin 'develop'
Sign in to join this conversation.
Reviewers
No reviewers
karel-m
Labels
Clear labels   
bug

   
duplicate

   
enhancement

   
feature

   
help wanted

   
improve API

   
invalid

   
needs documentation

   
not-planned
This ticket is not planned to be implemented and/or fixed from the core team.

  
rtfm

   
stale

   
support

   
wishlist
No labels
bug
duplicate
enhancement
feature
help wanted
improve API
invalid
needs documentation
not-planned
rtfm
stale
support
wishlist
Milestone
Clear milestone
No items
No milestone
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
gh-libtom/libtomcrypt!517
No description provided.