drop support of macOS 10.5 and earlier #121

Merged
Youw merged 2 commits from macos-drop-macos-workaround into master 2021-06-14 05:30:35 -05:00
Youw commented 2019-11-17 15:17:05 -06:00 (Migrated from github.com)

IOHIDDeviceGetService is available since macOS 10.6
dropping an old workaround makes the implementation simpler

Similar to #39.

Fixes #119
Closes #120

IOHIDDeviceGetService is available since macOS 10.6 dropping an old workaround makes the implementation simpler Similar to #39. Fixes #119 Closes #120
Youw commented 2019-11-29 11:57:31 -06:00 (Migrated from github.com)

Any votes against?

Any votes against?
z3ntu commented 2019-11-29 12:43:55 -06:00 (Migrated from github.com)

I'm fine personally with 10.6.8+ being supported. But there are definitely still people with macOS versions lower than 10.6 that are interested in software on those devices (see e.g. https://github.com/mistydemeo/tigerbrew - this is not just PPC but now everything < 10.9 or something because homebrew dropped support for macOS versions lower than that)

I'm fine personally with 10.6.8+ being supported. But there are definitely still people with macOS versions lower than 10.6 that are interested in software on those devices (see e.g. https://github.com/mistydemeo/tigerbrew - this is not just PPC but now everything < 10.9 or something because homebrew dropped support for macOS versions lower than that)
Youw commented 2019-11-29 12:54:34 -06:00 (Migrated from github.com)

In this particular example, tigerbrew Formula is still using signal11's copy of the repo: (current master) github.com/mistydemeo/tigerbrew@4cce1912cc/Library/Formula/hidapi.rb

In this particular example, tigerbrew Formula is still using signal11's copy of the repo: (current master) https://github.com/mistydemeo/tigerbrew/blob/4cce1912cc68a15a0d47f5744b489ae68dfe94fa/Library/Formula/hidapi.rb
Youw commented 2019-11-29 12:55:15 -06:00 (Migrated from github.com)

Maybe it is time, to finally fire a new release, and it will be a last release, that supports macOS 10.5.

Maybe it is time, to finally fire a new release, and it will be a last release, that supports macOS 10.5.
todbot commented 2019-11-29 14:14:56 -06:00 (Migrated from github.com)

I'm fine with this PR. MacOS USB & HID pre-10.6 always had weirdnesses and new macos adoption rate is typically very high among its users.

If we're talking new releases (yay), I like to lobby for https://github.com/libusb/hidapi/pull/125 being included.

I'm fine with this PR. MacOS USB & HID pre-10.6 always had weirdnesses and new macos adoption rate is typically very high among its users. If we're talking new releases (yay), I like to lobby for https://github.com/libusb/hidapi/pull/125 being included.
kevin-- (Migrated from github.com) approved these changes 2020-02-10 18:44:39 -06:00
LudovicRousseau (Migrated from github.com) approved these changes 2020-03-28 12:53:34 -05:00
mcuee commented 2021-01-26 20:18:46 -06:00 (Migrated from github.com)

Good to update and merge this one if it has not been merged.

Good to update and merge this one if it has not been merged.
mcuee commented 2021-06-13 20:47:11 -05:00 (Migrated from github.com)

@Youw Please merge this as well. Thanks.

@Youw Please merge this as well. Thanks.
Sign in to join this conversation.
No milestone
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
gh-libusb/hidapi!121
No description provided.