drop support of macOS 10.5 and earlier #121
No reviewers
Labels
No labels
3rdparty
Android
API
Author does not respond
bsd
bug
build system/CI
ci-virtual-device
CMake
Contributions Welcome
Core
dependencies
device-specific
documentation
don't_merge
duplicate
enhancement
Example
Haiku
hidraw
hotplug
info required
invalid
libusb
macOS
Misc
Not an issue
question
Release
Test
Test GUI
Windows
wontfix
No milestone
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
gh-libusb/hidapi!121
Loading…
Reference in a new issue
No description provided.
Delete branch "macos-drop-macos-workaround"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
IOHIDDeviceGetService is available since macOS 10.6
dropping an old workaround makes the implementation simpler
Similar to #39.
Fixes #119
Closes #120
Any votes against?
I'm fine personally with 10.6.8+ being supported. But there are definitely still people with macOS versions lower than 10.6 that are interested in software on those devices (see e.g. https://github.com/mistydemeo/tigerbrew - this is not just PPC but now everything < 10.9 or something because homebrew dropped support for macOS versions lower than that)
In this particular example, tigerbrew Formula is still using signal11's copy of the repo: (current master)
github.com/mistydemeo/tigerbrew@4cce1912cc/Library/Formula/hidapi.rbMaybe it is time, to finally fire a new release, and it will be a last release, that supports macOS 10.5.
I'm fine with this PR. MacOS USB & HID pre-10.6 always had weirdnesses and new macos adoption rate is typically very high among its users.
If we're talking new releases (yay), I like to lobby for https://github.com/libusb/hidapi/pull/125 being included.
Good to update and merge this one if it has not been merged.
@Youw Please merge this as well. Thanks.