Fix documentation generation #16
Labels
No labels
3rdparty
Android
API
Author does not respond
bsd
bug
build system/CI
ci-virtual-device
CMake
Contributions Welcome
Core
dependencies
device-specific
documentation
don't_merge
duplicate
enhancement
Example
Haiku
hidraw
hotplug
info required
invalid
libusb
macOS
Misc
Not an issue
question
Release
Test
Test GUI
Windows
wontfix
No milestone
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
gh-libusb/hidapi!16
Loading…
Reference in a new issue
No description provided.
Delete branch "doxygen"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
The first commit is auto-generated with
doxygen -uThe second commit fixes most of the doc generation being wrong, because the "relative indentation" in hidapi.h comments was being intepreted as codeblocks.
The third commit fixes a warning because in the hid_read_timeout documentation the parameter-name "device" was used but the function used "dev". As all other functions use "device", adjust the function.
The result looks good, but
doxygen -ugives so unreadable diff.Maybe manually change only what need to be updated (remove obsolete/add missing options)?
That's why I made them separate commits - but future updates to the Doxyfile should be much smaller as this is a bump over several years of versions (if it's needed at all).
In all implementations (in .c files) there is
dev. I would prefer to change doxygen text to@param devinstead of changingdevtodevicein function declaration.And rename commit title accordingly
On the other hand - in all other places in this
.h- it isdevice, so either we rename everywhere, or havedeviceeverywhere (I prefer more readable form for documentation).hid_device *devlooks readable to me anddevis pretty standard abbreviation for device. But in the end, I would be okay with both optionssure
in any case - better if we keep consistency across entire file
I've pushed an update that renames the
hid_device *deviceparameters tohid_device *devin the header file and in theregister_errormethod.Great, looks good