remove superfluous whitespace at end of lines #215

Closed
prusnak wants to merge 1 commit from whitespace-cleanup into master
prusnak commented 2020-11-26 14:16:40 -06:00 (Migrated from github.com)

This PR removes superfluous whitespace at end of lines

As can be seen here, only whitespace changes are included - https://github.com/libusb/hidapi/pull/215/commits/2f110a5028523a590da9885d7aeac43dc6799b3b?w=1

This PR removes superfluous whitespace at end of lines As can be seen here, only whitespace changes are included - https://github.com/libusb/hidapi/pull/215/commits/2f110a5028523a590da9885d7aeac43dc6799b3b?w=1
Youw commented 2020-11-26 14:29:10 -06:00 (Migrated from github.com)

Do you think it is really so much needed?
There is not much development going on, but when one tries to investigate an issue/find out why certain things are implemented this way, and not the other - changes like this makes it a bit more difficult to investigate the history of changes.

Do you think it is really so much needed? There is not much development going on, but when one tries to investigate an issue/find out why certain things are implemented this way, and not the other - changes like this makes it a bit more difficult to investigate the history of changes.
prusnak commented 2020-11-26 14:36:08 -06:00 (Migrated from github.com)

I don't mind it that MUCH, but my editor shows whitespace and some files have ridiculous amount of extra whitespace, so it triggers me a bit :D

https://github.com/libusb/hidapi/pull/215/files#diff-bdce61d76faf6ea305f64cd6c5dc7d26887efc0ef63a73c2b77f1da09d095aa1L749-L750 is a prime example

I don't mind it that MUCH, but my editor shows whitespace and some files have ridiculous amount of extra whitespace, so it triggers me a bit :D https://github.com/libusb/hidapi/pull/215/files#diff-bdce61d76faf6ea305f64cd6c5dc7d26887efc0ef63a73c2b77f1da09d095aa1L749-L750 is a prime example
Youw commented 2020-11-26 14:49:47 -06:00 (Migrated from github.com)

Yeah, I know the filling :)

For the reason of "not clutter the history" I vote not to merge it.

Yeah, I know the filling :) For the reason of "not clutter the history" I vote not to merge it.
Youw commented 2021-03-07 06:18:34 -06:00 (Migrated from github.com)

As much as I love the idea of having a clean code base, at this point lets preserve commit history.
Maybe we'll come back to it some time later.

As much as I love the idea of having a clean code base, at this point lets preserve commit history. Maybe we'll come back to it some time later.

Pull request closed

Sign in to join this conversation.
No reviewers
No milestone
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
gh-libusb/hidapi!215
No description provided.