remove superfluous whitespace at end of lines #215
No reviewers
Labels
No labels
3rdparty
Android
API
Author does not respond
bsd
bug
build system/CI
ci-virtual-device
CMake
Contributions Welcome
Core
dependencies
device-specific
documentation
don't_merge
duplicate
enhancement
Example
Haiku
hidraw
hotplug
info required
invalid
libusb
macOS
Misc
Not an issue
question
Release
Test
Test GUI
Windows
wontfix
No milestone
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
gh-libusb/hidapi!215
Loading…
Reference in a new issue
No description provided.
Delete branch "whitespace-cleanup"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
This PR removes superfluous whitespace at end of lines
As can be seen here, only whitespace changes are included - https://github.com/libusb/hidapi/pull/215/commits/2f110a5028523a590da9885d7aeac43dc6799b3b?w=1
Do you think it is really so much needed?
There is not much development going on, but when one tries to investigate an issue/find out why certain things are implemented this way, and not the other - changes like this makes it a bit more difficult to investigate the history of changes.
I don't mind it that MUCH, but my editor shows whitespace and some files have ridiculous amount of extra whitespace, so it triggers me a bit :D
https://github.com/libusb/hidapi/pull/215/files#diff-bdce61d76faf6ea305f64cd6c5dc7d26887efc0ef63a73c2b77f1da09d095aa1L749-L750 is a prime example
Yeah, I know the filling :)
For the reason of "not clutter the history" I vote not to merge it.
As much as I love the idea of having a clean code base, at this point lets preserve commit history.
Maybe we'll come back to it some time later.
Pull request closed