hidtest: don't use a C++ source file, since it's pure C #22

Merged
z3ntu merged 1 commit from pr_249 into master 2019-06-25 07:09:12 -05:00
z3ntu commented 2019-06-17 05:02:40 -05:00 (Migrated from github.com)

This allows to build the test program with toolchains that don't have
C++ support.

Signed-off-by: Thomas Petazzoni thomas.petazzoni@free-electrons.com

Originally https://github.com/signal11/hidapi/pull/249

This allows to build the test program with toolchains that don't have C++ support. Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> Originally https://github.com/signal11/hidapi/pull/249
jdk (Migrated from github.com) reviewed 2019-06-17 05:02:40 -05:00
todbot (Migrated from github.com) reviewed 2019-06-17 05:02:40 -05:00
Qbicz (Migrated from github.com) reviewed 2019-06-17 05:02:40 -05:00
z3ntu commented 2019-06-17 05:03:23 -05:00 (Migrated from github.com)

The cpp file is still referenced in

windows/hidtest.vcproj:                         RelativePath="..\hidtest\hidtest.cpp"

This should be updated as well I think?

EDIT: Done. I hope it still builds on Windows like that ;)

The cpp file is still referenced in ``` windows/hidtest.vcproj: RelativePath="..\hidtest\hidtest.cpp" ``` This should be updated as well I think? **EDIT:** Done. I hope it still builds on Windows like that ;)
Youw (Migrated from github.com) approved these changes 2019-06-24 17:55:09 -05:00
Youw (Migrated from github.com) left a comment

the changes looks reasonable, but I'm unable to verify right now on my PC(s)

CI would do great here

the changes looks reasonable, but I'm unable to verify right now on my PC(s) CI would do great here
z3ntu commented 2019-06-25 03:42:42 -05:00 (Migrated from github.com)

I can't 100% verify that the Windows version builds fine because of an additional commit needed for appveyor (vs2015); but in general it still builds fine: https://ci.appveyor.com/project/z3ntu/hidapi/builds/25520538/job/64xs7pjqx1mhas4q

I can't 100% verify that the Windows version builds fine because of an additional commit needed for appveyor (vs2015); but in general it still builds fine: https://ci.appveyor.com/project/z3ntu/hidapi/builds/25520538/job/64xs7pjqx1mhas4q
Youw commented 2019-06-25 07:01:06 -05:00 (Migrated from github.com)

additional commit needed for appveyor (vs2015)

we can fix any possible issues when it comes to it
so far looks good

> additional commit needed for appveyor (vs2015) we can fix any possible issues when it comes to it so far looks good
Youw commented 2019-06-25 07:09:06 -05:00 (Migrated from github.com)

compiles on Windows with automatic conversion of .sln by MSVC2017

compiles on Windows with automatic conversion of `.sln` by MSVC2017
Sign in to join this conversation.
No milestone
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
gh-libusb/hidapi!22
No description provided.