Update hid.c #260

2021-04-08T09:08:28-05:00

MonkeybreadSoftware commented

2021-04-08 09:08:28 -05:00

(Migrated from github.com)

Put back in HIDIOCSFEATURE define as it's missing for us.

MonkeybreadSoftware commented

2021-04-08 09:09:34 -05:00

(Migrated from github.com)

We build hidapi here for 11 platforms. Lot's of combinations of compilers and platforms, but not all have the HIDIOCSFEATURE define yet.

z3ntu commented

2021-04-08 10:00:30 -05:00

(Migrated from github.com)

You're building for kernels older than 2.6.39? We don't have support for those anymore in hidapi, so even if it builds it probably doesn't work at runtime.

👍 1

MonkeybreadSoftware commented

2021-04-08 11:44:39 -05:00

(Migrated from github.com)

The build machine is old to avoid some libc dependencies.
The actual machine running the code is usually newer.

And yes, I know we should update it to something newer.

The build machine is old to avoid some libc dependencies. The actual machine running the code is usually newer. And yes, I know we should update it to something newer.

Youw (Migrated from github.com) reviewed

2021-04-08 12:07:22 -05:00

linux/hid.c

				`@ -45,6 +45,22 @@`

Since we dropped support of the old 2.6.39 kernel, I'd rather prefer if hidapi build would fail by default on those.

@MonkeybreadSoftware would this compromise work for you?

#ifdef HIDAPI_ALLOW_BUILD_WORKAROUND_KERNEL_2_6_39
/* This definitions first appeared in Linux Kernel 2.6.39 in linux/hidraw.h.
    hidapi doesn't support kernels older than that,
    so we don't define macros below explicitly, to fail builds on old kernels.
    For those who really need this as a workaround (e.g. to be able to build on old build machines),
    can workaround by defining the macro above.
*/
#ifndef HIDIOCSFEATURE
#define HIDIOCSFEATURE(len)    _IOC(_IOC_WRITE|_IOC_READ, 'H', 0x06, len)
#endif
#ifndef HIDIOCGFEATURE
#define HIDIOCGFEATURE(len)    _IOC(_IOC_WRITE|_IOC_READ, 'H', 0x07, len)
#endif

#endif

Since we dropped support of the old `2.6.39` kernel, I'd rather prefer if hidapi build would fail by default on those. @MonkeybreadSoftware would this compromise work for you? ```suggestion #ifdef HIDAPI_ALLOW_BUILD_WORKAROUND_KERNEL_2_6_39 /* This definitions first appeared in Linux Kernel 2.6.39 in linux/hidraw.h. hidapi doesn't support kernels older than that, so we don't define macros below explicitly, to fail builds on old kernels. For those who really need this as a workaround (e.g. to be able to build on old build machines), can workaround by defining the macro above. */ #ifndef HIDIOCSFEATURE #define HIDIOCSFEATURE(len) _IOC(_IOC_WRITE|_IOC_READ, 'H', 0x06, len) #endif #ifndef HIDIOCGFEATURE #define HIDIOCGFEATURE(len) _IOC(_IOC_WRITE|_IOC_READ, 'H', 0x07, len) #endif #endif ```