gh-libusb/hidapi

Watch

Windows: hid_get_feature/input_report return size fix #334

Merged

Youw merged 2 commits from win_fix_feature into master

2021-09-27 05:07:03 -05:00

Youw commented

2021-09-22 09:34:26 -05:00

(Migrated from github.com)

It appears when the numbered reports aren't used,
WinAPI returns size of the report excluding the data[0] which contains 0,
as an indication that numbered reports aren't used;
Explicity count that byte in the result.

Fixes: #328

- It appears when the numbered reports aren't used, WinAPI returns size of the report excluding the data[0] which contains 0, as an indication that numbered reports aren't used; Explicity count that byte in the result. Fixes: #328

mcuee (Migrated from github.com) approved these changes

2021-09-27 02:09:07 -05:00

mcuee commented

2021-09-27 02:16:12 -05:00

(Migrated from github.com)

As mentioned in #328, the fixes for the feature report should be correct.

As mentioned in #328, the fixes for the feature report should be correct.

mcuee commented

2021-09-27 02:22:29 -05:00

(Migrated from github.com)

However, hidapitester can not be used to test the fix to the input report as it uses hid_read_timeout().
https://github.com/libusb/hidapi/issues/285#issuecomment-907570047

However, hidapitester can not be used to test the fix to the input report as it uses hid_read_timeout(). https://github.com/libusb/hidapi/issues/285#issuecomment-907570047

Sign in to join this conversation.

No reviewers

No labels

Author does not respond

build system/CI

ci-virtual-device

Contributions Welcome

device-specific

No milestone

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

gh-libusb/hidapi!334

No description provided.